Skip to content

fix: Cook run state 3: status, verdict, summary, notify and scheduler project CookRunState - #18507

Closed
chubes4 wants to merge 2 commits into
fix/issue-18436-homeboyfrom
fix/issue-18499-homeboy
Closed

chubes4 wants to merge 2 commits into
fix/issue-18436-homeboyfrom
fix/issue-18499-homeboy

Conversation

@chubes4

@chubes4 chubes4 commented Nov 18, 2026

Copy link
Copy Markdown
Member

Summary

Cook run state 3: status, verdict, summary, notify and scheduler project CookRunState. Review form unavailable: agent_task.provider_cancelled; completion not assessed; deterministic gates passed

What changed

  • Cook run state 3: status, verdict, summary, notify and scheduler project CookRunState

Verification

  • 2-verify-194fabc0129ce4a90d69f396041f7dfad35653be552de104cfe6bc624f183b5f.txt (cargo fmt --check): passed on 2699bdf. Base fix/issue-18436-homeboy@af136f8 advanced to 87a6d34. 12954 ms; retained gate metadata.

  • 3-verify-97abbbd2ffe64d2ede888d26337c6c105146db892f530a8a1328477a1db13564.txt (cargo check -p homeboy-core -p homeboy-agents -p homeboy-cli --all-targets): passed on 2699bdf. Base fix/issue-18436-homeboy@af136f8 advanced to 87a6d34. 156266 ms; retained gate metadata.

  • 4-verify-f6401ed85d7b0a6e2f3622f222798d4447309ec16e461166d6d4d0b9ca7bf9cc.txt (cargo test -p homeboy-lifecycle-contract -p homeboy-control-plane-contract --lib): passed (63/63) on 2699bdf. Base fix/issue-18436-homeboy@af136f8 advanced to 87a6d34. 15288 ms; retained gate metadata.

  • 5-verify-4cb9098726e9d7740354910331ca4e26c82be2aac9ffe34a862380c7696e69ae.txt (cargo test -p homeboy-agents --lib candidate_continuation -- --test-threads=1): passed (15/15) on 2699bdf. Base fix/issue-18436-homeboy@af136f8 advanced to 87a6d34. 290404 ms; retained gate metadata.

  • 6-verify-3c6e494f77a85c48b076eb2ae2b565b036e0c82a28585bdb46ed835f1c2494ad.txt (cargo test -p homeboy-agents --lib -- --test-threads=8): passed (2489/2491) on 2699bdf. Base fix/issue-18436-homeboy@af136f8 advanced to 87a6d34. 849285 ms; retained gate metadata.

  • HOMEBOY_LINT_BASE=af136f80823e8bf4283e3a318445650bbe84f356 homeboy --placement l (HOMEBOY_LINT_BASE=af136f80823e8bf4283e3a318445650bbe84f356 homeboy --placement local review lint homeboy --path . --cha…): passed on 2699bdf. Base fix/issue-18436-homeboy@af136f8 advanced to 87a6d34. 274525 ms; retained gate metadata.

  • repro: none (no repro gate was declared, so these gates do not prove the issue).

  • CI: pending

Cook run
  • Gate 1: tree c096053f0edf4981f34e7205cb9c67d06c7d44c7
  • Gate 2: tree c096053f0edf4981f34e7205cb9c67d06c7d44c7
  • Gate 3: tree c096053f0edf4981f34e7205cb9c67d06c7d44c7; 0 failed, 0 ignored
  • Gate 4: tree c096053f0edf4981f34e7205cb9c67d06c7d44c7; 0 failed, 0 ignored
  • Gate 5: tree c096053f0edf4981f34e7205cb9c67d06c7d44c7; 0 failed, 2 ignored
  • Gate 6: tree c096053f0edf4981f34e7205cb9c67d06c7d44c7

Evidence

  • External proof authorized by operator.
  • Recovery retained 6 infrastructure-invalid gate record(s).
  • Replacement proof covers 6 gate(s).

AI disclosure

Tool: Homeboy Cook. Agent: Homeboy (runner-child). Model: runner-child · route roadie/cook-heavy · served claude-opus-5-5, gpt-6.1-sol. Cook time: 1h48m.

Implementation and reviewer documentation were written by the AI, under the direction of the Cook requester. Gates were run by Homeboy. A human reviews before merge.

Closes #18499

@chubes4
chubes4 deleted the branch fix/issue-18436-homeboy November 18, 2026 23:31
@chubes4 chubes4 closed this Nov 18, 2026
@chubes4

chubes4 commented Nov 18, 2026

Copy link
Copy Markdown
Member Author

Closed automatically when its stacked base fix/issue-18436-homeboy was deleted on the #18495 merge. Rebased onto main; it will be replaced by a new PR from Cook agent-task-d8954459-67e5-4001-b4da-b2020f1d5e80. (Claude via Roadie.)

chubes4 added a commit that referenced this pull request Nov 19, 2026
#18511)

Slice 3 of #18436 (tracked in #18499). This replaces #18507, which
closed automatically when its stacked base `fix/issue-18436-homeboy` was
deleted on the #18495 merge. Rebased onto main, with no other changes.

## Summary
Every Cook read surface (status, cook verdict, summary, notify,
scheduler, durable-state probe) now projects `CookRunState::of(record)`
and `legal_actions()` instead of classifying `candidate_recoverable`,
running or stale itself. The status recovery step comes from the same
source as `recover`'s plan, so status no longer reports `none` where
recover would regate, publish or rearm.

## What changed
- Read surfaces route through `CookRunState` and `legal_actions()`.
Their local classification is deleted.
- Added a guard test (`read_projection_guard.rs`) that fails if
`candidate_recoverable` classification reappears outside the allowed
files.
- Fixed the status-vs-recover disagreement for
`gate_environment_unavailable`→regate, selected-attempt→publish, and
gate-feedback→rearm. The `candidate_continuation` tests cover all three.

## Verification
On candidate `2699bdf`, before the rebase:
- `cargo fmt --check`: passed.
- `cargo check -p homeboy-core -p homeboy-agents -p homeboy-cli
--all-targets`: passed.
- Contract crate tests: 63/63 passed.
- `candidate_continuation`, single-threaded: 15/15 passed.
- `homeboy-agents` lib: 2489 passed, 2 ignored, 0 failed.

After the rebase onto main, `cargo check` passes. A Cook rework run will
repeat the full gates on this PR.

## Remaining on #18436
- 1b, persisted CookRunState: #18498.
- Slice 4: subsystem enums as transitions.
- Slice 5: unified liveness.
- Slice 6: god-file splits.

## AI assistance
Homeboy Cook (roadie/cook-heavy, served claude-opus-5-5 and gpt-6.1-sol)
wrote the change. Claude (via Roadie/Pi) diagnosed the gate regressions,
rebased the branch, and opened this PR. Chris Huber directed the work
and owns it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant