Repository navigation
Conversation
Slice 3 of #18436. Cook candidate 725b8ed from agent-task-f7440029.
… project CookRunState
Member
Author
|
Closed automatically when its stacked base |
chubes4
added a commit
that referenced
this pull request
Nov 19, 2026
#18511) Slice 3 of #18436 (tracked in #18499). This replaces #18507, which closed automatically when its stacked base `fix/issue-18436-homeboy` was deleted on the #18495 merge. Rebased onto main, with no other changes. ## Summary Every Cook read surface (status, cook verdict, summary, notify, scheduler, durable-state probe) now projects `CookRunState::of(record)` and `legal_actions()` instead of classifying `candidate_recoverable`, running or stale itself. The status recovery step comes from the same source as `recover`'s plan, so status no longer reports `none` where recover would regate, publish or rearm. ## What changed - Read surfaces route through `CookRunState` and `legal_actions()`. Their local classification is deleted. - Added a guard test (`read_projection_guard.rs`) that fails if `candidate_recoverable` classification reappears outside the allowed files. - Fixed the status-vs-recover disagreement for `gate_environment_unavailable`→regate, selected-attempt→publish, and gate-feedback→rearm. The `candidate_continuation` tests cover all three. ## Verification On candidate `2699bdf`, before the rebase: - `cargo fmt --check`: passed. - `cargo check -p homeboy-core -p homeboy-agents -p homeboy-cli --all-targets`: passed. - Contract crate tests: 63/63 passed. - `candidate_continuation`, single-threaded: 15/15 passed. - `homeboy-agents` lib: 2489 passed, 2 ignored, 0 failed. After the rebase onto main, `cargo check` passes. A Cook rework run will repeat the full gates on this PR. ## Remaining on #18436 - 1b, persisted CookRunState: #18498. - Slice 4: subsystem enums as transitions. - Slice 5: unified liveness. - Slice 6: god-file splits. ## AI assistance Homeboy Cook (roadie/cook-heavy, served claude-opus-5-5 and gpt-6.1-sol) wrote the change. Claude (via Roadie/Pi) diagnosed the gate regressions, rebased the branch, and opened this PR. Chris Huber directed the work and owns it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cook run state 3: status, verdict, summary, notify and scheduler project CookRunState. Review form unavailable: agent_task.provider_cancelled; completion not assessed; deterministic gates passed
What changed
Verification
2-verify-194fabc0129ce4a90d69f396041f7dfad35653be552de104cfe6bc624f183b5f.txt (
cargo fmt --check): passed on2699bdf. Basefix/issue-18436-homeboy@af136f8advanced to87a6d34. 12954 ms; retained gate metadata.3-verify-97abbbd2ffe64d2ede888d26337c6c105146db892f530a8a1328477a1db13564.txt (
cargo check -p homeboy-core -p homeboy-agents -p homeboy-cli --all-targets): passed on2699bdf. Basefix/issue-18436-homeboy@af136f8advanced to87a6d34. 156266 ms; retained gate metadata.4-verify-f6401ed85d7b0a6e2f3622f222798d4447309ec16e461166d6d4d0b9ca7bf9cc.txt (
cargo test -p homeboy-lifecycle-contract -p homeboy-control-plane-contract --lib): passed (63/63) on2699bdf. Basefix/issue-18436-homeboy@af136f8advanced to87a6d34. 15288 ms; retained gate metadata.5-verify-4cb9098726e9d7740354910331ca4e26c82be2aac9ffe34a862380c7696e69ae.txt (
cargo test -p homeboy-agents --lib candidate_continuation -- --test-threads=1): passed (15/15) on2699bdf. Basefix/issue-18436-homeboy@af136f8advanced to87a6d34. 290404 ms; retained gate metadata.6-verify-3c6e494f77a85c48b076eb2ae2b565b036e0c82a28585bdb46ed835f1c2494ad.txt (
cargo test -p homeboy-agents --lib -- --test-threads=8): passed (2489/2491) on2699bdf. Basefix/issue-18436-homeboy@af136f8advanced to87a6d34. 849285 ms; retained gate metadata.HOMEBOY_LINT_BASE=af136f80823e8bf4283e3a318445650bbe84f356 homeboy --placement l (
HOMEBOY_LINT_BASE=af136f80823e8bf4283e3a318445650bbe84f356 homeboy --placement local review lint homeboy --path . --cha…): passed on2699bdf. Basefix/issue-18436-homeboy@af136f8advanced to87a6d34. 274525 ms; retained gate metadata.repro: none (no repro gate was declared, so these gates do not prove the issue).
CI: pending
Cook run
c096053f0edf4981f34e7205cb9c67d06c7d44c7c096053f0edf4981f34e7205cb9c67d06c7d44c7c096053f0edf4981f34e7205cb9c67d06c7d44c7; 0 failed, 0 ignoredc096053f0edf4981f34e7205cb9c67d06c7d44c7; 0 failed, 0 ignoredc096053f0edf4981f34e7205cb9c67d06c7d44c7; 0 failed, 2 ignoredc096053f0edf4981f34e7205cb9c67d06c7d44c7Evidence
AI disclosure
Tool: Homeboy Cook. Agent: Homeboy (runner-child). Model: runner-child · route roadie/cook-heavy · served claude-opus-5-5, gpt-6.1-sol. Cook time: 1h48m.
Implementation and reviewer documentation were written by the AI, under the direction of the Cook requester. Gates were run by Homeboy. A human reviews before merge.
Closes #18499