Repository navigation
refactor(agent-task): Cook read surfaces project CookRunState (#18499) - #18511
Merged
Merged
Conversation
Slice 3 of #18436. Cook candidate 725b8ed from agent-task-f7440029.
… project CookRunState
Member
Author
|
Verified on rebased head |
chubes4
marked this pull request as ready for review
November 19, 2026 03:23
This was referenced Nov 19, 2026
This was referenced Nov 19, 2026
Merged
chubes4
added a commit
that referenced
this pull request
Nov 19, 2026
…8511 read projections (#18524) Main is red after #18510 and #18511 merged one after the other. Each PR was green against its own base. Together, these fail deterministically on the Lab and in CI: - `homeboy-agents orchestration::tests::review_preserves_authoritative_aggregate_absence`: expected `CandidateRecoverable`, got `Succeeded`. - `homeboy-agents agent_task_service::cook::tests::cook_observation_agrees_across_real_stores_without_mutation` - `homeboy-cli …status_run_fixtures::agent_task_status_published_receipt_wins_over_terminal_and_promotion_snapshots` Bisect: 1ae3148 (before #18510) passes, and c303bf1 (#18510) fails. #18510 makes the persisted CookRunState override derivation, while #18511's read projections and these tests depend on the derived verdict. One example is an unverified success that reads as `CandidateRecoverable`. This reverts #18510's CookRunState persistence. It keeps #18510's unrelated `deps.rs` fix, where a deadline that wins the cancel race stays a timeout. #18498 reopens so the persistence can reland rebased on #18511. Lab at this SHA: the 3 tests above pass, and `cook_run_state` passes 5/5. --- Written by Claude (claude-opus via Claude Code): bisected the red main and prepared the revert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice 3 of #18436 (tracked in #18499). This replaces #18507, which closed automatically when its stacked base
fix/issue-18436-homeboywas deleted on the #18495 merge. Rebased onto main, with no other changes.Summary
Every Cook read surface (status, cook verdict, summary, notify, scheduler, durable-state probe) now projects
CookRunState::of(record)andlegal_actions()instead of classifyingcandidate_recoverable, running or stale itself. The status recovery step comes from the same source asrecover's plan, so status no longer reportsnonewhere recover would regate, publish or rearm.What changed
CookRunStateandlegal_actions(). Their local classification is deleted.read_projection_guard.rs) that fails ifcandidate_recoverableclassification reappears outside the allowed files.gate_environment_unavailable→regate, selected-attempt→publish, and gate-feedback→rearm. Thecandidate_continuationtests cover all three.Verification
On candidate
2699bdf, before the rebase:cargo fmt --check: passed.cargo check -p homeboy-core -p homeboy-agents -p homeboy-cli --all-targets: passed.candidate_continuation, single-threaded: 15/15 passed.homeboy-agentslib: 2489 passed, 2 ignored, 0 failed.After the rebase onto main,
cargo checkpasses. A Cook rework run will repeat the full gates on this PR.Remaining on #18436
AI assistance
Homeboy Cook (roadie/cook-heavy, served claude-opus-5-5 and gpt-6.1-sol) wrote the change. Claude (via Roadie/Pi) diagnosed the gate regressions, rebased the branch, and opened this PR. Chris Huber directed the work and owns it.