Skip to content

Fix build checks #1826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
imalcolm1 wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Fix build checks #1826

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c2ed011
Fix not building source generator
imalcolm1 Jul 31, 2026
852967c
Fix build check targets
imalcolm1 Aug 5, 2026
b91de24
Force netstandard2.0 for all CatalogGenerator imports
imalcolm1 Aug 6, 2026
7fd2157
Revert "Fix not building source generator"
imalcolm1 Aug 6, 2026
3e6da31
Shorten winui clone path
imalcolm1 Aug 6, 2026
6c927d0
Update targetframeworks in catalog generator
imalcolm1 Aug 7, 2026
d9ff80a
Revert targetframeworks change and set targetframework as local property
imalcolm1 Aug 7, 2026
7a72b4c
Revert "Shorten winui clone path"
imalcolm1 Aug 7, 2026
42d2d27
Reapply "Fix not building source generator"
imalcolm1 Aug 7, 2026
9a2e4a4
Any CPU is now an alias for x64 in the wpf store project and the cata…
imalcolm1 Aug 7, 2026
fc68382
Revert "Any CPU is now an alias for x64 in the wpf store project and …
imalcolm1 Aug 7, 2026
ae3ea40
Make the build success check use the ci build script instead
imalcolm1 Aug 7, 2026
a1c7f87
Undo treate targetframework as local property in cataloggenerator
imalcolm1 Aug 7, 2026
ea3a337
Revert "Make the build success check use the ci build script instead"
imalcolm1 Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/BuildSuccess_Check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,19 +27,19 @@ jobs:
uses: microsoft/setup-msbuild@v2
- name: Build MAUI (Windows)
run: |
msbuild /restore /t:Build src/MAUI/ArcGIS.Samples.MAUI.sln /p:Configuration=Release /p:CentralPackageManagementEnabled=true /p:TargetFramework=net9.0-windows10.0.19041.0 /p:RuntimeIdentifier=win10-x64 /p:RuntimeIdentifierOverride=win10-x64 /p:UseRidGraph=true
msbuild /restore /t:Build src/MAUI/ArcGIS.Samples.MAUI.sln /p:Configuration=Release /p:CentralPackageManagementEnabled=true /p:TargetFramework=net10.0-windows10.0.19041.0 /p:RuntimeIdentifier=win10-x64 /p:RuntimeIdentifierOverride=win10-x64 /p:UseRidGraph=true

- name: Build MAUI (Android)
run: |
msbuild /restore /t:Build src/MAUI/ArcGIS.Samples.MAUI.sln /p:Configuration=Release /p:CentralPackageManagementEnabled=true /p:TargetFramework=net9.0-android
msbuild /restore /t:Build src/MAUI/ArcGIS.Samples.MAUI.sln /p:Configuration=Release /p:CentralPackageManagementEnabled=true /p:TargetFramework=net10.0-android

- name: Build MAUI (iOS)
run: |
msbuild /restore /t:Build src/MAUI/ArcGIS.Samples.MAUI.sln /p:Configuration=Release /p:CentralPackageManagementEnabled=true /p:TargetFramework=net9.0-ios
msbuild /restore /t:Build src/MAUI/ArcGIS.Samples.MAUI.sln /p:Configuration=Release /p:CentralPackageManagementEnabled=true /p:TargetFramework=net10.0-ios

- name: Build MAUI (Mac)
run: |
msbuild /restore /t:Build src/MAUI/ArcGIS.Samples.MAUI.sln /p:Configuration=Release /p:CentralPackageManagementEnabled=true /p:TargetFramework=net9.0-maccatalyst
msbuild /restore /t:Build src/MAUI/ArcGIS.Samples.MAUI.sln /p:Configuration=Release /p:CentralPackageManagementEnabled=true /p:TargetFramework=net10.0-maccatalyst


# WPF .NET Build
Expand Down
3 changes: 2 additions & 1 deletion src/MAUI/Maui.Samples/ArcGIS.Samples.Maui.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,8 @@
<ProjectReference Include="..\..\Samples.CatalogGenerator\Samples.CatalogGenerator.csproj"
OutputItemType="Analyzer"
ReferenceOutputAssembly="false"
PrivateAssets="all" />
PrivateAssets="all"
SetTargetFramework="TargetFramework=netstandard2.0" />
</ItemGroup>

<!-- WinUIEx is used to workaround the lack of a WebAuthenticationBroker for WinUI. https://github.com/microsoft/WindowsAppSDK/issues/441 -->
Expand Down
2 changes: 1 addition & 1 deletion src/WPF/WPF.StorePackage/ArcGIS.WPF.StorePackage.wapproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
<None Include="ArcGIS.WPF.StorePackage_TemporaryKey.pfx" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\WPF.Viewer\ArcGIS.WPF.Viewer.Net.csproj" AdditionalProperties="TargetFramework=net8.0-windows10.0.19041.0">

@imalcolm1 imalcolm1 Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not absolutely necessary given the later commit to force netstandard2.0 on the CatalogGenerator references, but the target framework is about to be outdated and not needed anyway

<ProjectReference Include="..\WPF.Viewer\ArcGIS.WPF.Viewer.Net.csproj">
<PublishProfile Condition="'$(Configuration)|$(Platform)'=='Release|x64'">Properties\PublishProfiles\win-x64-release.pubxml</PublishProfile>
<PublishProfile Condition="'$(Configuration)|$(Platform)'=='Release|ARM64'">Properties\PublishProfiles\win-arm64-release.pubxml</PublishProfile>
</ProjectReference>
Expand Down
3 changes: 2 additions & 1 deletion src/WPF/WPF.Viewer/ArcGIS.WPF.Viewer.Net.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@
<ProjectReference Include="..\..\Samples.CatalogGenerator\Samples.CatalogGenerator.csproj"
OutputItemType="Analyzer"
ReferenceOutputAssembly="false"
PrivateAssets="all" />
PrivateAssets="all"
SetTargetFramework="TargetFramework=netstandard2.0" />
</ItemGroup>
<ItemGroup>
<Compile Update="Converters\*.cs">
Expand Down
3 changes: 2 additions & 1 deletion src/WinUI/ArcGIS.WinUI.Viewer/ArcGIS.WinUI.Viewer.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@
<ProjectReference Include="..\..\Samples.CatalogGenerator\Samples.CatalogGenerator.csproj"
OutputItemType="Analyzer"
ReferenceOutputAssembly="false"
PrivateAssets="all" />
PrivateAssets="all"
SetTargetFramework="TargetFramework=netstandard2.0" />
</ItemGroup>

<ItemGroup>
Expand Down
Loading