Skip to content

Fix build checks - #1826

Draft
imalcolm1 wants to merge 14 commits into
mainfrom
ian/fix-wpf-store-build
Draft

Fix build checks#1826
imalcolm1 wants to merge 14 commits into
mainfrom
ian/fix-wpf-store-build

Conversation

@imalcolm1

@imalcolm1 imalcolm1 commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Description

WPF Store build:
The explicit target framework was causing an error when building the source generator as it only has the netstandard2.0 target framework. Forced the CatalogGenerator references to target netstandard2.0 on all projects.

Maui build check:
Was still targeting net9.0. It also had the same problem and solution as WPF with the CatalogGenerator TFM.

WinUI build check:
File path length was exceeded. Updated the action to specify a shorter clone path.

Type of change

  • Bug fix

Platforms tested on

  • WPF
  • WinUI
  • Maui Windows
  • Maui Android
  • Maui iOS
  • Maui Catalyst

Checklist

  • Self-review of changes
  • All changes work as expected on all affected platforms
  • There are no warnings related to changes
  • Code is commented and follows .NET conventions and standards
  • Codemaid and XAML styler extensions have been run on every changed file
  • No unrelated changes have been made to any other code or project files
  • Screenshots are correct size and display in description tab (800 x 600 on Windows, MAUI mobile platforms use the MAUI Windows screenshot)

@imalcolm1 imalcolm1 self-assigned this Aug 4, 2026
@imalcolm1
imalcolm1 changed the base branch from v.next to main August 5, 2026 19:36
@imalcolm1
imalcolm1 force-pushed the ian/fix-wpf-store-build branch from 790e194 to c2ed011 Compare August 5, 2026 22:42
@imalcolm1 imalcolm1 changed the title Fix WPF store build Fix builds Aug 5, 2026
<None Include="ArcGIS.WPF.StorePackage_TemporaryKey.pfx" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\WPF.Viewer\ArcGIS.WPF.Viewer.Net.csproj" AdditionalProperties="TargetFramework=net8.0-windows10.0.19041.0">

@imalcolm1 imalcolm1 Aug 6, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not absolutely necessary given the later commit to force netstandard2.0 on the CatalogGenerator references, but the target framework is about to be outdated and not needed anyway

@imalcolm1 imalcolm1 changed the title Fix builds Fix build checks Aug 6, 2026
@imalcolm1
imalcolm1 force-pushed the ian/fix-wpf-store-build branch from 1c9f6fc to 6c927d0 Compare August 7, 2026 02:26
@imalcolm1
imalcolm1 force-pushed the ian/fix-wpf-store-build branch from 9ccda3d to 9a2e4a4 Compare August 7, 2026 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant