Fix build checks - #1826
Draft
imalcolm1 wants to merge 14 commits into
Draft
Conversation
imalcolm1
force-pushed
the
ian/fix-wpf-store-build
branch
from
August 5, 2026 22:42
790e194 to
c2ed011
Compare
imalcolm1
commented
Aug 6, 2026
| <None Include="ArcGIS.WPF.StorePackage_TemporaryKey.pfx" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <ProjectReference Include="..\WPF.Viewer\ArcGIS.WPF.Viewer.Net.csproj" AdditionalProperties="TargetFramework=net8.0-windows10.0.19041.0"> |
Collaborator
Author
There was a problem hiding this comment.
This change is not absolutely necessary given the later commit to force netstandard2.0 on the CatalogGenerator references, but the target framework is about to be outdated and not needed anyway
This reverts commit c2ed011.
imalcolm1
force-pushed
the
ian/fix-wpf-store-build
branch
from
August 7, 2026 02:26
1c9f6fc to
6c927d0
Compare
imalcolm1
force-pushed
the
ian/fix-wpf-store-build
branch
from
August 7, 2026 03:04
9ccda3d to
9a2e4a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
WPF Store build:
The explicit target framework was causing an error when building the source generator as it only has the netstandard2.0 target framework. Forced the CatalogGenerator references to target netstandard2.0 on all projects.
Maui build check:
Was still targeting net9.0. It also had the same problem and solution as WPF with the CatalogGenerator TFM.
WinUI build check:
File path length was exceeded. Updated the action to specify a shorter clone path.
Type of change
Platforms tested on
Checklist