Added the timesync input connection to the Fake HSI object in the FakeHSIApplication - #220
Merged
Merged
Conversation
…eHSIApplication, so that it can correctly appear in our configuration diagrams and other diagnostic tools.
eflumerf
approved these changes
Jul 7, 2025
eflumerf
left a comment
eflumerf
left a comment
Member
There was a problem hiding this comment.
LGTM. small_footprint_quick_test uses FakeHSI, verified that it still works.
…SI_timesync_input
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…, so that it will correctly appear in our configuration diagrams and other diagnostic tools.
We've noticed that the TimeSync "connection" into the FakeHSI application is missing in our configuration diagrams. The change in this PR fixes that. I'll add before/after diagrams to this PR.
To see the results of these changes, we can run
generate_modules_test local-1x1-config hsi-fake-01 config/daqsystemtest/example-configs.data.xmlor run
create_config_plot -f config/daqsystemtest/example-configs.data.xml -s local-1x1-config, etcThis PR will have a follow-up one in
hsilibs, in which we make use of the TimeSync connection that is providing in the confguration...