Modified FakeHSIEventGeneratorModule to make use of the TimeSync conn… - #75
Merged
bieryAtFnal merged 2 commits intoJul 15, 2025
Merged
Conversation
added 2 commits
July 3, 2025 11:51
…ection specified in the configuration (now that we have one) instead of using a hard-coded wildcard.
…TimeSync Receiver creation now in init() method).
eflumerf
approved these changes
Jul 7, 2025
eflumerf
left a comment
eflumerf
left a comment
Member
There was a problem hiding this comment.
LGTM. small_footprint_quick_test uses FakeHSI, verified that it still works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ection specified in the configuration (now that we have one) instead of using a hard-coded wildcard.
This PR depends on appmodel PR 220.
That PR in
appmodeladded the TimeSync input connection to FakeHSI applications. The changes in this PR modify theFakeHSIEventGeneratorModulecode to make use of that new entry in the configuration.It would be great for reviewer(s) to confirm that the code changes look reasonable.
Beyond that, I believe that testing these changes will consist of verifying that they don't break anything.