docs(adr): correct — Noema is one shared runtime per CWL-MASTER-CONTEXT, not separate contexts - #1527
docs(adr): correct — Noema is one shared runtime per CWL-MASTER-CONTEXT, not separate contexts#1527seonghobae wants to merge 3 commits into
Conversation
…iew core The owner asked for Noema to be developed as an Agent naruon can also use, not only a PR-review CI workflow (DDD). Reading .github's scripts/ci/noema_review_gate.py end to end shows its only reusable core is a single-shot diff-review verdict generator (one fixed prompt/JSON schema keyed on changed-diff lines); everything else is GitHub PR CI glue. Naruon already has its own, actively developed general-purpose Noema agent (backend/services/noema_agent.py, pydantic-ai, mail/content-graph/task tools) that does not need or use that diff-review core — see the open, active naruon#1486 (calendar conflict-check tool) and naruon#1384 (tenant-scoped contextual-orchestrator gateway slice). This ADR records that finding durably: the two Noemas are separate Bounded Contexts sharing only a name, per docs/product-goal-directive.md §5's Shared-Kernel-minimization convention, so the "share only a name" reasoning survives beyond PR prose (which this investigation found can be lost — see the closed, since-repurposed .github#1437/#1438).
|
Important Approval pendingCodeRabbit has no unresolved comments, but it has not reviewed the latest commit. Use the checkbox below to review the latest commit. CodeRabbit will approve the changes if it finds no blocking issues.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Current Naruon architecture has one material contradiction with this ADR that must be resolved before it can become authority. The two agent bounded contexts may remain separate ( Please keep the useful DDD conclusion (no shared
This does not imply sharing |
…te Bounded Contexts The original ADR-0006 concluded naruon's Noema and .github's CI-review Noema are "intentionally separate" and should never share code, based only on reading current code in both repos. That never checked docs/CWL-MASTER-CONTEXT.md in ContextualWisdomLab/.github, which is explicit: "noema — agent runtime (Pydantic-AI / Codex-Python): a GitHub Review Agent in CI + a do-anything agent inside naruon + the lightweight quarantine sandbox" and "noema is the shared agent runtime + quarantine sandbox (used by naruon, the GitHub review agent, and wardnet's AI SOC)". Owner confirmed this directly: compatibility across the two was the intended design from the start, not a coincidence of naming. This commit marks the ADR superseded-on-arrival, keeps the original investigation for record (its code-level findings are accurate, only the "therefore keep them permanently separate" conclusion was wrong), and points at the real follow-up: design the shared Pydantic-AI Noema runtime + quarantine-sandbox capability the master context describes, with .github's diff-review logic and naruon's multi-tool agent logic as two callers of that shared core. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Fresh owner-contract verification after the correction found that this PR still cannot be accepted as current architecture. Therefore the newly added “one shared agent runtime + quarantine sandbox” correction is itself stale relative to the current protected owner repository and should not be promoted into an Accepted/Superseded Naruon ADR as canonical truth. Please refetch the live Noema PRD/TRD/ARCHITECTURE/README and the active Noema writer path before changing this branch again, then make this Naruon ADR describe only Naruon’s consumer boundary:
A durable cross-repo unification decision, if still desired, belongs first in the Noema owner path and must publish a versioned contract that Naruon can consume. Until then, the safest Naruon state is to record the observed drift without inventing a shared runtime that the current owner does not ship. Please keep this PR non-authoritative/Draft or rewrite it to that consumer-boundary statement; do not transfer review/check evidence after the head moves. |
…012) ADR-0006's 2026-09-02 correction promised a follow-up shared-runtime design without naming it yet. That design has since landed as ContextualWisdomLab/noema's ADR-0012 (docs/adr/0012-shared-noema-core-package.md, noema#536): a minimal noema-core package holding only the pydantic-ai Agent-construction wiring, extracted from noema's reviewer/ first (self-consumption only). Naruon's own adoption is that ADR's explicit PR #2, sequenced after noema#536 merges and after this repository's naruon#1486/#1384 merge-order conflict resolves — not done here. Points both the correction section and the Consequences list at the concrete ADR/PR instead of leaving "follow-up work" as an unnamed promise. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Pushed a follow-up commit: pointed this ADR's correction section and Consequences list at the design that resolves its "follow-up work" promise — |
|
PR governance metadata gate is not ready for
|
|
[codex] Current develop head 042b0c7 and this PR head have unrelated histories, so allowing unrelated histories would mix repository histories. Successor #1557 starts from the live remote develop head and carries forward this PR valid DDD boundary, research references, active-lane traceability, and follow-up intent while replacing claims contradicted by Noema protected main. The earlier #1556 used a stale local tracking ref, had no unique delta after #1557, and was closed. This predecessor remains open; do not transfer checks or reviews, and do not close it until #1557 full-delta succession is independently verified. |
2026-09-02 correction to my own earlier PR: the ADR this PR adds originally concluded naruon's Noema and
.github's CI-review Noema are "intentionally separate" and should never share code. That was wrong — I only read current code in both repos and never checkeddocs/CWL-MASTER-CONTEXT.mdinContextualWisdomLab/.github, which explicitly defines Noema as one shared agent runtime (Pydantic-AI / Codex-Python) with three consumers: the GitHub review agent in CI, a do-anything agent inside naruon, and wardnet's AI SOC (including the quarantine sandbox, i.e.ContextualWisdomLab/quarantine-sandbox-runtime). The repo owner confirmed directly that compatibility across these was the intended design from the start.This PR now updates ADR-0006 in place to mark it superseded-on-arrival: the original code-level investigation (what
.github's and naruon's current Noema implementations actually do) is kept and remains accurate, but the "therefore keep them permanently separate" conclusion is withdrawn. The real follow-up — designing the actual shared runtime the master context describes — is tracked separately, not settled by this ADR.See naruon#1486 for a follow-up comment correcting the same wrong framing there.
🤖 Generated with Claude Code