Skip to content

perf(ipd): evaluate explicit factor levels with equivalence coverage #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
seonghobae wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

perf(ipd): evaluate explicit factor levels with equivalence coverage #323

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3466e7a
perf: optimize IPDgroup factor creation with explicit levels
seonghobae Sep 2, 2026
249217b
test(ipd): characterize explicit factor level equivalence
seonghobae Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,6 @@
## 2025-02-12 - R 언어에서 반복적인 mirt 모델 생성 시 불필요한 데이터프레임 부분집합 추출 최적화
**Learning:** R에서 데이터프레임의 특정 열을 추출하는 작업(`df[cols]`)은 O(N)의 메모리 복사를 수반합니다. `autoFIPC`에서 `mirt` 모델의 파라미터를 설정하거나 호출하는 과정 중에 `newformXDataK[colnames(newFormModel@Data$data)]` 코드가 반복해서 사용되었고, 심지어 `ncol()`을 위해 단순히 개수를 구할 때도 사용되어 불필요한 메모리 할당과 오버헤드를 초래했습니다.
**Action:** 조건문이나 반복문 내부에서 불필요하게 데이터프레임 부분집합 연산이 반복되지 않도록 외부에서 한 번만 `linkedFormData <- newformXDataK[colnames(newFormModel@Data$data)]`로 캐싱(caching)한 뒤, `ncol(linkedFormData)`와 `data = linkedFormData` 형태로 재사용하여 메모리 복사와 O(N) 오버헤드를 방지해야 합니다.
## 2026-09-02 - R 언어에서 factor 생성 시 명시적 수준 지정으로 O(N) 오버헤드 최적화
**Learning:** R에서 `as.factor()`를 사용해 요인을 생성하면 데이터를 스캔하고 정렬하여 레벨을 추론하는 오버헤드가 발생합니다.
**Action:** 레벨이 이미 알려진 경우 `factor(..., levels = c(...))` 형식으로 레벨을 명시적으로 제공하여 추론 과정을 우회하고 성능을 최적화할 수 있습니다.

@devin-ai-integration devin-ai-integration Bot Sep 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Optimization remains linear

Explicit levels skip discovery and sorting, but factor() still encodes every observation. The O(N) elimination claim overstates the optimization.

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

4 changes: 2 additions & 2 deletions R/aFIPC.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,10 +613,10 @@ autoFIPC <-
if (checkIPD == T) {
# config
IPDgroup <-
as.factor(c(
factor(c(
rep('oldForm', nrow(oldformYDataK)),
rep('newForm', nrow(newformXDataK))
))
), levels = c('newForm', 'oldForm'))
Comment on lines +616 to +619

@devin-ai-integration devin-ai-integration Bot Sep 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Info: Group reference semantics stay stable

as.factor() ordered these labels as newForm, then oldForm. The explicit order preserves encoding and reference-group selection across every estimation branch.

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

IPDItemCount <- 0

# IPD target item checking
Expand Down
Loading