Skip to content

perf(ipd): evaluate explicit factor levels with equivalence coverage #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
seonghobae wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

perf(ipd): evaluate explicit factor levels with equivalence coverage #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3466e7a
perf: optimize IPDgroup factor creation with explicit levels
seonghobae Sep 2, 2026
249217b
test(ipd): characterize explicit factor level equivalence
seonghobae Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions R/aFIPC.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,10 +613,10 @@ autoFIPC <-
if (checkIPD == T) {
# config
IPDgroup <-
as.factor(c(
factor(c(
rep('oldForm', nrow(oldformYDataK)),
rep('newForm', nrow(newformXDataK))
))
), levels = c('newForm', 'oldForm'))
Comment on lines +616 to +619

@devin-ai-integration devin-ai-integration Bot Sep 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Info: Group reference semantics stay stable

as.factor() ordered these labels as newForm, then oldForm. The explicit order preserves encoding and reference-group selection across every estimation branch.

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

IPDItemCount <- 0

# IPD target item checking
Expand Down
19 changes: 19 additions & 0 deletions tests/testthat/test-ipdgroup-factor-equivalence.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
test_that("explicit IPD group levels preserve the protected factor contract", {
cardinalities <- list(
c(old_form = 1L, new_form = 1L),
c(old_form = 3L, new_form = 5L),
c(old_form = 37L, new_form = 61L)
)

for (sizes in cardinalities) {
labels <- c(
rep("oldForm", sizes[["old_form"]]),
rep("newForm", sizes[["new_form"]])
)
protected <- as.factor(labels)
candidate <- factor(labels, levels = c("newForm", "oldForm"))

expect_identical(candidate, protected)
expect_identical(levels(candidate), c("newForm", "oldForm"))
}
})
Loading