Skip to content

fix(e2e): the same ambiguous locator, one file over #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubenvdlinde merged 1 commit into from
Sep 7, 2026
Merged

fix(e2e): the same ambiguous locator, one file over #645

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions tests/e2e/spec-coverage/lock-screen.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,12 +132,29 @@ test.describe('Lock screen — spec: encryption-suites/spec.md', () => {
.first()
.click({ force: true })

// Error note card appears and we remain on the lock screen.
// THE MESSAGE IS ON TWO SURFACES ON PURPOSE, and each is asserted on
// its own. The helper text under the field is what a sighted reader
// sees; the visually-hidden role="alert" is what a screen reader
// announces, and it was added deliberately so a rejected credential
// interrupts rather than going unspoken.
//
// A single `.lock-screen`-wide text match resolved to BOTH and failed
// under strict mode on a correct page. Narrowing it to either one
// alone would let the other be removed without a test noticing, which
// for the live region means losing the announcement silently.
//
// The identical locator in `../workflows/vault-unlock.spec.ts` was
// fixed in #642 and this copy was missed, so development stayed red on
// the same defect one file over. Two files, one pattern: grep for the
// locator, not for the spec that happened to fail.
const wrongPassword = /Wrong master password|decryption failed/i
await expect(page.locator(`${LockScreen} [role="alert"]`)).toHaveText(
wrongPassword,
{ timeout: 15_000 },
)
await expect(
page
.locator(LockScreen)
.getByText(/Wrong master password|decryption failed/i),
).toBeVisible({ timeout: 15_000 })
page.locator(`${LockScreen} .input-field__helper-text-message`),
).toHaveText(wrongPassword, { timeout: 15_000 })
await expect(lockHeading(page)).toHaveText(/Unlock Keepiq/i)
await expect(page).toHaveURL(/\/lock/)
})
Expand Down
Loading