Skip to content

refactor(dossiq): use the openregister main object API - #6581

Merged
rubenvdlinde merged 4 commits into
developmentfrom
quality/ormig-dossiq
Nov 15, 2026
Merged

rubenvdlinde merged 4 commits into
developmentfrom
quality/ormig-dossiq

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

What changed

OpenRegister main changed the object service's published signatures: find(), findSilent(), saveObject(), saveObjects(), deleteObject(), patchObject(), lockObject() and unlockObject() take option objects (ObjectFindOptions, ObjectSaveOptions, ObjectDeletion, ObjectPatch, LockRequest, UnlockRequest, BulkSaveOptions) where the release took named arguments such as register: and schema:. dossiq now calls the main form everywhere. The same register, schema, uuid, extend and flags reach OpenRegister; only their packaging changed.

Also moved to main's API:

  • Flow nodes implement ICallFlowNode, bulk actions StepBulkActionInterface (both already took FlowNodeCall / BulkStep).
  • SideEffectDispatcher and RetiredActionRunner run a node through FlowNodeInvoker, so a node in either form runs.
  • EngineInboxQuery builds TaskInboxCriteria from its audience and selection parts; an unknown filter still fails as an unknown parameter.
  • EngineTaskGateway::complete() passes a FormCompletionRequest; IntakeFormBindingCheck passes a FormDestination; IntakeFormDependentsListener builds FormDependent from a PublishedForm.

Tests: the OpenRegister stubs follow main (including the drifted ones: ObjectServiceInterface, IFlowNode, BulkActionInterface, LifecycleActionInterface, Bootstrap::register, TaskInboxCriteria, FlowEmailSentEvent, the form classes, TaskFormCompletion, the decision events), and the doubles take main's arguments. tests/Support/LegacyObjectArgs lets a recording double keep asserting on register/schema/uuid.

Call sites

  • Before: 146 call sites on lib/ that main rejects (80 typed, 66 by name), plus positional calls the name check does not see; 314 calls rewritten in total.
  • After: none. A scan of lib/ against main's signatures finds only app-local methods that share a name.

Left as they are, because their argument shape is already invalid on the release as well as on main (changing them would change behaviour):

  • lib/Repair/FoldCasePropertiesOntoCase.php (find($caseId, ['_rbac' => false, ...]), saveObject($schema, $case, [...]))
  • lib/Service/ObjectSchemaSlugResolver.php:132, lib/Service/Settings/SchemaSlugResolver.php:130 (SchemaMapper::find(id, register:))
  • lib/Service/CaseDefinition/PackageSchemaReferences.php:204, lib/Service/Intake/IntakeSourceSeeder.php:155, lib/Service/Settings/SchemaSlugResolver.php:172 (RegisterMapper::find(id, _extend:))

Verified locally (openregister main @ 3800106 checked out beside the app, as CI does)

  • Unit suite before: 13 StubApiDriftTest failures against main (plus 16 that only need a composer-installed sibling).
  • Unit suite after: 18166 tests, 0 failures, 0 errors (4 warnings, as before). StubApiDriftTest is green.
  • php -l on every changed file; phpcs on changed lib files: no new errors; phpstan on changed lib files: one inherited finding (DocumentRecordStore::$dossierRegister, untouched).
  • development merged in before the final run.

Needs

This app now needs an OpenRegister release cut from main; the 9 Nov release still has the old signatures. appinfo/info.xml declares no OpenRegister minimum, so there is nothing to raise.

AI assistance: prepared with Claude Code.

🤖 Generated with Claude Code

OpenRegister main takes option objects where the release took named
arguments: find(id, ObjectFindOptions), saveObject(object,
ObjectSaveOptions), deleteObject(ObjectDeletion), patchObject(ObjectPatch),
lockObject(LockRequest) and unlockObject(UnlockRequest). The same register,
schema, uuid, extend and flags now travel inside those objects.

Flow nodes implement ICallFlowNode and bulk actions StepBulkActionInterface,
and node calls go through FlowNodeInvoker. Task inbox criteria, form
completion, form destinations, form dependents and FlowEmailSentEvent follow
main's value objects. The test stubs and doubles follow main's signatures.

Assisted-by: ClaudeCode:claude-opus-5-5
…object API

Assisted-by: ClaudeCode:claude-opus-5-5
@rubenvdlinde
rubenvdlinde merged commit 2d949c5 into development Nov 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/dossiq @ dc007cc

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ❌
psalm ❌
phpstan ❌
phpmetrics ✅
eslint ❌
stylelint ✅
build ✅
check-manifest ✅
check-vue3-compile ✅
test-l10n ❌
format ❌
check-schema-l10n ❌
check-l10n-js ❌
check-debt-ratchet ❌
check-types-e2e ✅
composer ❌ ✅ 109/109
npm ✅ ✅ 656/656
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ❌ 5635/5647 · 3 skipped
Newman ⏭️
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-15 19:30 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant