Repository navigation
refactor(dossiq): use the openregister main object API - #6581
Merged
Merged
Conversation
OpenRegister main takes option objects where the release took named arguments: find(id, ObjectFindOptions), saveObject(object, ObjectSaveOptions), deleteObject(ObjectDeletion), patchObject(ObjectPatch), lockObject(LockRequest) and unlockObject(UnlockRequest). The same register, schema, uuid, extend and flags now travel inside those objects. Flow nodes implement ICallFlowNode and bulk actions StepBulkActionInterface, and node calls go through FlowNodeInvoker. Task inbox criteria, form completion, form destinations, form dependents and FlowEmailSentEvent follow main's value objects. The test stubs and doubles follow main's signatures. Assisted-by: ClaudeCode:claude-opus-5-5
…object API Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
November 15, 2026 19:17
Contributor
Quality Report — ConductionNL/dossiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue3-compile | ✅ | ||||
| test-l10n | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ❌ | ||||
| check-l10n-js | ❌ | ||||
| check-debt-ratchet | ❌ | ||||
| check-types-e2e | ✅ | ||||
| composer | ❌ | ✅ 109/109 | |||
| npm | ✅ | ✅ 656/656 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ 5635/5647 · 3 skipped | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-15 19:30 UTC
Download the full PDF report from the workflow artifacts.
This was referenced Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
OpenRegister
mainchanged the object service's published signatures:find(),findSilent(),saveObject(),saveObjects(),deleteObject(),patchObject(),lockObject()andunlockObject()take option objects (ObjectFindOptions,ObjectSaveOptions,ObjectDeletion,ObjectPatch,LockRequest,UnlockRequest,BulkSaveOptions) where the release took named arguments such asregister:andschema:. dossiq now calls themainform everywhere. The same register, schema, uuid, extend and flags reach OpenRegister; only their packaging changed.Also moved to
main's API:ICallFlowNode, bulk actionsStepBulkActionInterface(both already tookFlowNodeCall/BulkStep).SideEffectDispatcherandRetiredActionRunnerrun a node throughFlowNodeInvoker, so a node in either form runs.EngineInboxQuerybuildsTaskInboxCriteriafrom its audience and selection parts; an unknown filter still fails as an unknown parameter.EngineTaskGateway::complete()passes aFormCompletionRequest;IntakeFormBindingCheckpasses aFormDestination;IntakeFormDependentsListenerbuildsFormDependentfrom aPublishedForm.Tests: the OpenRegister stubs follow
main(including the drifted ones:ObjectServiceInterface,IFlowNode,BulkActionInterface,LifecycleActionInterface,Bootstrap::register,TaskInboxCriteria,FlowEmailSentEvent, the form classes,TaskFormCompletion, the decision events), and the doubles takemain's arguments.tests/Support/LegacyObjectArgslets a recording double keep asserting onregister/schema/uuid.Call sites
mainrejects (80 typed, 66 by name), plus positional calls the name check does not see; 314 calls rewritten in total.main's signatures finds only app-local methods that share a name.Left as they are, because their argument shape is already invalid on the release as well as on
main(changing them would change behaviour):lib/Repair/FoldCasePropertiesOntoCase.php(find($caseId, ['_rbac' => false, ...]),saveObject($schema, $case, [...]))lib/Service/ObjectSchemaSlugResolver.php:132,lib/Service/Settings/SchemaSlugResolver.php:130(SchemaMapper::find(id, register:))lib/Service/CaseDefinition/PackageSchemaReferences.php:204,lib/Service/Intake/IntakeSourceSeeder.php:155,lib/Service/Settings/SchemaSlugResolver.php:172(RegisterMapper::find(id, _extend:))Verified locally (openregister
main@ 3800106 checked out beside the app, as CI does)StubApiDriftTestfailures againstmain(plus 16 that only need a composer-installed sibling).StubApiDriftTestis green.php -lon every changed file; phpcs on changed lib files: no new errors; phpstan on changed lib files: one inherited finding (DocumentRecordStore::$dossierRegister, untouched).developmentmerged in before the final run.Needs
This app now needs an OpenRegister release cut from
main; the 9 Nov release still has the old signatures.appinfo/info.xmldeclares no OpenRegister minimum, so there is nothing to raise.AI assistance: prepared with Claude Code.
🤖 Generated with Claude Code