refactor(dossiq): lock and unlock documents through a LockRequest - #5358
Closed
rubenvdlinde wants to merge 3 commits into
Closed
rubenvdlinde wants to merge 3 commits into
rubenvdlinde wants to merge 3 commits into
Conversation
openregister #9095 changes lockObject() and unlockObject() to take a LockRequest and an UnlockRequest. The DRC lock and unlock endpoints build them from the document uuid. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
November 10, 2026 12:08
Contributor
Quality Report — ConductionNL/dossiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ❌ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue3-compile | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ❌ | ||||
| check-l10n-js | ✅ | ||||
| check-debt-ratchet | ❌ | ||||
| check-types-e2e | ✅ | ||||
| composer | ❌ | ✅ 109/109 | |||
| npm | ✅ | ✅ 657/657 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ 3909/3944 · 3 skipped | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-10 22:57 UTC
Download the full PDF report from the workflow artifacts.
… Kernel\Contracts\Value [skip ci] OpenRegister main defines them there; the Service\Object names existed only in the test stubs, so lock and unlock failed at runtime. The stubs move to the same namespace. Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5 # Conflicts: # lib/Controller/DrcController.php
Contributor
Author
|
Superseded by #6581 (merged into development), which moves every find/saveObject/deleteObject/patchObject/lock call and flow node in this app to openregister main's option objects in one pass, test doubles included. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after openregister #9095 lands.
LockRequest,UnlockRequestandLockRunStepare new inOCA\OpenRegister\Service\Objectin #9095, so this has to land with #9095 or after it.Fixed (file -> new call)
lib/Controller/DrcController.php:876:lockObject(identifier: $uuid)->lockObject(request: new LockRequest(identifier: $uuid))lib/Controller/DrcController.php:1017:unlockObject(identifier: $uuid)->unlockObject(request: new UnlockRequest(identifier: $uuid))Tests
tests/Stubs/Contract/ObjectServiceInterface.php: both methods on #9095's signature. The three value-object stubs are copied from #9095's head.DrcDownloadLockContractTestandDrcControllerContractTest: the doubled interfaces and the lock callback and unlockwith()take the request objects.What ran
php -land phpcs (no errors) on the controller.--no-coverageon every test that uses the object-service interface stub or the DRC controller: green.AI disclosure: prepared with Claude Code (claude-opus-5-5).