Skip to content

fix(timeline): prevent mobile horizontal overflow #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ErikBjare merged 1 commit into from
Sep 6, 2026
Merged

fix(timeline): prevent mobile horizontal overflow #971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/components/InputTimeInterval.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,11 @@ div
display: grid;
// Fixed label column keeps Mode/Range labels aligned and the controls
// start at the same X regardless of which mode is active.
grid-template-columns: 4rem 1fr;
grid-template-columns: 4rem minmax(0, 1fr);
column-gap: 0.75rem;
row-gap: 0.5rem;
align-items: center;
min-width: 0;
}

.btn-group {
Expand All @@ -81,6 +82,16 @@ div
border-color: #495057;
}
}

@media (max-width: 575.98px) {
.time-interval-grid {
grid-template-columns: 1fr;
}

.btn-group {
flex-wrap: wrap;
}
}
</style>

<script lang="ts">
Expand Down
13 changes: 13 additions & 0 deletions test/e2e/screenshot.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,12 @@ async function checkNoError(t) {
}
}

async function checkNoHorizontalOverflow(t) {
await t
.expect(Selector('html').scrollWidth)
.lte(await t.eval(() => document.documentElement.clientWidth));
}

const logJsErrorCode = `
window.addEventListener('error', function (e) {
console.error(e.message);
Expand Down Expand Up @@ -140,6 +146,13 @@ test.clientScripts({
fullPage: true,
});
await checkNoError(t);
});

test('Timeline has no horizontal page overflow on mobile', async t => {
await t.resizeWindow(360, 800);
await hide_devonly(t);
await waitForLoading(t);
await checkNoHorizontalOverflow(t);

// Debugging
// console.log(await t.getBrowserConsoleMessages());
Expand Down
Loading