fix(timeline): prevent mobile horizontal overflow - #971
Conversation
Git-Session-Id: 8a48
6c48f5a to
6d05535
Compare
Greptile SummaryThis PR prevents the Timeline interval controls from widening mobile pages and adds an end-to-end regression check.
Confidence Score: 5/5The PR appears safe to merge, with no outstanding correctness or repository-rule violations. The responsive CSS directly addresses the intrinsic-width overflow and the mobile end-to-end test exercises the Timeline route at the reported viewport. The previous workflow comment-target issue is fixed by targeting ActivityWatch/aw-webui, and the previous ScreenTime merge-key issue is fixed by selecting merge keys according to the mobile source type. Important Files Changed
Reviews (2): Last reviewed commit: "fix(timeline): prevent mobile horizontal..." | Re-trigger Greptile |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #971 +/- ##
=======================================
Coverage 51.99% 51.99%
=======================================
Files 48 48
Lines 2927 2927
Branches 652 685 +33
=======================================
Hits 1522 1522
Misses 1385 1385
Partials 20 20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Greptile reviewed the pre-rebase fork ancestry rather than this PR diff. Current base→head changes only |
|
@greptileai review |
Summary
Reproduction
At a 360px viewport on current
master,document.documentElement.scrollWidthis 450px. TheInputTimeIntervalgrid is 433px wide because its1frtrack and unwrapped button groups preserve their intrinsic width.After this change, document width remains 360px and the grid is 326px wide.
Verification
./node_modules/.bin/jest --selectProjects jsdom --runInBand test/unit/VisTimeline.test.js(8 passed)./node_modules/.bin/vue-cli-service lint src/components/InputTimeInterval.vue test/e2e/screenshot.test.jsPRE_COMMIT_ALLOW_NO_CONFIG=1 prek run --files src/components/InputTimeInterval.vue test/e2e/screenshot.test.jsRelated: ActivityWatch/activitywatch#1430