fix completion page to show test results - #370
Merged
saa938 merged 2 commits intoAug 14, 2026
Merged
Conversation
5 tasks
Showing the completion page unmounts Header, so continuing on to the results remounts it with a fresh countdown at the full test duration. When that timer expired it re-fired setSubmitted(true), which now routes through handleSetSubmitted and flipped showCompletionPage back on -- throwing the user from their results back to the completion page, once per test duration, indefinitely. Measured on a 12-second test: it returned 11.8s after Continue and again 11.5s later, interrupting a question explanation mid-read. Ignore repeat submits so the restarted timer can't re-trigger it. Also fix the footer's primary button on the results page. Its label was keyed on currentQuestionIndex === questions.length - 1, but submitting resets the index to 0, so it read "Next" while actually triggering the exit confirm. Branch on showReviewPage first; pre-submit labels are unchanged, since the review page was previously only reachable from the last question.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
right now, the completion page's continue page goes to home screen instead of viewing results. After the pr, it should go to the results screen
Pull request type
Checklist