Repository navigation
feat: implement Z-X bialgebra rewrite rule - #189
Merged
Merged
Conversation
dlyongemallo
marked this pull request as ready for review
February 1, 2026 21:55
dlyongemallo
marked this pull request as draft
February 1, 2026 21:55
There was a problem hiding this comment.
Pull request overview
Implements a Z–X bialgebra rewrite rule in the ZX-calculus core rules and adds a dedicated test suite to validate its correctness (including scalar factors and boundary handling).
Changes:
- Added
check_bialg,bialg_unchecked, and the checked wrapperbialgimplementing the Z–X bialgebra rule with appropriate structural and phase preconditions. - Implemented the bialgebra transformation to remove the central Z/X spiders, connect their neighborhoods bipartitely with normal edges, and apply the
sqrt(2)^((m-1)*(n-1))scalar factor. - Added a comprehensive set of unit tests covering basic, boundary, asymmetric, and non-matching cases for the bialgebra rule, verifying semantic preservation via
to_tensor4().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dlyongemallo
marked this pull request as ready for review
February 2, 2026 06:30
dlyongemallo
marked this pull request as draft
February 2, 2026 06:31
dlyongemallo
marked this pull request as ready for review
February 2, 2026 06:32
ABorgna
enabled auto-merge
November 1, 2026 19:44
ABorgna
approved these changes
Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.