Deactivate active light color loops before color commands - #832
Draft
dmulcahey wants to merge 1 commit into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #832 +/- ##
==========================================
+ Coverage 97.19% 97.25% +0.06%
==========================================
Files 57 57
Lines 10560 10575 +15
==========================================
+ Hits 10264 10285 +21
+ Misses 296 290 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dmulcahey
force-pushed
the
codex-updated-pr-733
branch
from
September 5, 2026 19:07
bc5acaf to
3ce5ad8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an illuminated light is running a color loop, sending a color or color-temperature command before disabling the loop can leave the requested color unapplied. Stop the known active loop first. If deactivation fails, retain the effect state and skip dependent color commands while still allowing independent on/brightness/flash work.
Retain the existing late-deactivation path for a light that is off with a remembered loop; that case is not claimed as newly fixed. Effect state changes only after successful activation/deactivation responses. Tests cover command ordering, inactive/off guards, failure responses, and independent commands.
Addresses home-assistant/core#153431 and zigpy/backlog#48. Updated replacement for #733; no broader light/effect redesign.
Validation against
devat66603431339afe37fa0048b70ff31d77dceb8f95: Python 3.12 full suite, 1391 passed, coverage above the 95% project gate; full pre-commit (codespell, Ruff, formatting, mypy, lock check) passed. Relevant regression checks fail on the unchanged base. GitHub CI for Python 3.12/3.13/3.14 is reported separately on the PR.