Fix thermostat rounding and Sinope polling idempotency - #830
Draft
dmulcahey wants to merge 1 commit into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #830 +/- ##
=======================================
Coverage 97.19% 97.20%
=======================================
Files 57 57
Lines 10560 10573 +13
=======================================
+ Hits 10264 10277 +13
Misses 296 296 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dmulcahey
force-pushed
the
codex-updated-pr-688
branch
from
September 5, 2026 19:07
7a51205 to
c31c6f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converting a requested thermostat setpoint with
int(value * 100)can lose a centidegree to floating-point representation (for example, 19.9 becomes 1989). Useround()for heating/cooling and occupied/away setpoints, with positive and negative precision coverage.Sinope time updates also need one task across repeated enable/disable calls. Keep ownership until cancellation finishes, restart only if re-enabled, and prevent restarts after entity removal. Lifecycle tests cover repeated enable, rapid disable/re-enable, and removal while cancellation is pending.
Supersedes #688.
Validation against
devat66603431339afe37fa0048b70ff31d77dceb8f95: Python 3.12 full suite, 1384 passed, coverage above the 95% project gate; full pre-commit (codespell, Ruff, formatting, mypy, lock check) passed. Relevant regression checks fail on the unchanged base. GitHub CI for Python 3.12/3.13/3.14 is reported separately on the PR.