Skip to content

Fix once-only and awaitable event listeners - #829

Draft
dmulcahey wants to merge 1 commit into
devfrom
codex-updated-pr-687
Draft

Fix once-only and awaitable event listeners#829
dmulcahey wants to merge 1 commit into
devfrom
codex-updated-pr-687

Conversation

@dmulcahey

@dmulcahey dmulcahey commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

An asynchronous once() listener is not unsubscribed until its task runs, so two immediate emits can invoke it twice. Reentrant emits can also revisit a listener captured by an outer emit. Callable objects with asynchronous __call__, and synchronous callbacks returning awaitables, are currently left unscheduled.

Consume once-listeners synchronously and schedule/track the value returned by a callback when it is awaitable. ensure_future() accepts both coroutines and existing futures/tasks. Regression tests cover back-to-back and reentrant emits, async callable objects, and returned futures/tasks.

Supersedes #687. This refresh is limited to event delivery; it drops the unrelated concurrency-limit validation and periodic-cancellation behavior changes.

Validation against dev at 66603431339afe37fa0048b70ff31d77dceb8f95: Python 3.12 full suite, 1387 passed, coverage above the 95% project gate; full pre-commit (codespell, Ruff, formatting, mypy, lock check) passed. Relevant regression checks fail on the unchanged base. GitHub CI for Python 3.12/3.13/3.14 is reported separately on the PR.

@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.19%. Comparing base (6660343) to head (4691fd0).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #829   +/-   ##
=======================================
  Coverage   97.19%   97.19%           
=======================================
  Files          57       57           
  Lines       10560    10560           
=======================================
  Hits        10264    10264           
  Misses        296      296           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmulcahey dmulcahey changed the title Codex updated: Fix async/event lifecycle edge cases Fix once-only and awaitable event listeners Sep 5, 2026
@dmulcahey
dmulcahey force-pushed the codex-updated-pr-687 branch from aaf05cd to 4691fd0 Compare September 5, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant