Bump bellows 1.0.0 -> 1.0.1 - #2032
Merged
Merged
Conversation
Patch release, two upstream fixes: - Fix EmberStatus.NETWORK_BUSY mapping to sl_Status.BUSY (was incorrectly mapped to ZIGBEE_MAX_MESSAGE_LIMIT_REACHED) (zigpy/bellows#743) - Fix spurious "Unknown status" warning from XNCP replies on Simplicity SDK firmware; introduces a dedicated XncpStatus enum for the XNCP frame status byte (zigpy/bellows#744) Neither change touches API surface used by this repo: grepped Classes/ZigpyTransport/ for NETWORK_BUSY, sl_Status, XncpCommand, XncpStatus, send_xncp_frame - no matches. The only bellows-specific symbols referenced here, ash.NcpFailure and types.named.NcpResetCode.ERROR_EXCEEDED_MAXIMUM_ACK_TIMEOUT_COUNT (AppGeneric.py), are untouched by this release and confirmed present unchanged in the 1.0.1 source. Verified in a scratch venv against constraints.txt: pytest (1366 passed), flake8 (E9,F63,F7,F82 clean).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zigpy,zigpy-znp,zigpy-deconz,zigpy-blzare already pinned at their latest published versions on PyPI — no changes needed.bellowshas a new patch release, 1.0.0 -> 1.0.1, soconstraints.txtis bumped.Upstream changelog (1.0.0...1.0.1)
EmberStatus.NETWORK_BUSYnot mapping tosl_Status.BUSYzigpy/bellows#743 — FixEmberStatus.NETWORK_BUSYmapping tosl_Status.BUSY(was incorrectly mapped toZIGBEE_MAX_MESSAGE_LIMIT_REACHED). Touchesbellows/types/named.py.XncpStatusenum for the XNCP frame status byte instead of reusingEmberStatus/sl_Status. Touchesbellows/ezsp/__init__.py,bellows/ezsp/xncp.py.Impact assessment
Grepped
Classes/ZigpyTransport/,Modules/,Zigbee/, andplugin.pyfor every symbol touched by the two changes above:NETWORK_BUSY,sl_Status,XncpCommand,XncpStatus,send_xncp_frame,MAX_MESSAGE_LIMIT_REACHED— no matches. This repo does not use the XNCP subsystem or referencesl_Status/EmberStatusroute-failure mapping directly.The only bellows-specific symbols this repo does reference are
bellows.ash.NcpFailureandbellows.types.named.NcpResetCode.ERROR_EXCEEDED_MAXIMUM_ACK_TIMEOUT_COUNT, used inClasses/ZigpyTransport/AppGeneric.py(inline-imported, watchdog/connection-loss handling around line 465-468). Neither is touched by 1.0.1; both confirmed present and unchanged by fetchingbellows/ash.pyandbellows/types/named.pyat the1.0.1tag directly from source.Test plan
bellows==1.0.1in a scratch venv against this repo'sconstraints.txt/requirements.txtpytest .— 1366 passedflake8 . --select=E9,F63,F7,F82— clean🤖 Generated with Claude Code
https://claude.ai/code/session_015HCTiAQYy7iAMYAEo6Tcrm