Repository navigation
fix(1.5.9-rc): keep result cards stable across remake and un-squeeze reveal button - #653
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the jarring result-page card flip and button crowding observed on
2d37667d(/Users/zhoukk/AutoClipQA/文档/问题记录-同项目再做后结果页切换-20261122.md):OutputVariantCardacross remake (StudioResults.tsx):generation.auto_start = falsewhile retaining existingworkspace.output_variants.StudioResultsswitched the entire grid onautomatic ? output_variants : drafts, immediately unmountingOutputVariantCardand replacing it withDraftResultCard(changing badge, title, layout, video state, and button copy in place).output_variantsremain mounted asOutputVariantCardeven afterauto_startflips tofalse, while any newly created standalone drafts (!variantDraftIds.has(d.id)) render alongside them asDraftResultCard.StudioResults.tsx):再做一版(already translated in all 8 locales and matching the再做一版dialog title) instead of the redundant 9-char用同一素材再做一个jumping to再做一版.再做一版reachable whenvariants.length > 0even ifhideLegacyis enabled.StudioDownloadLink.tsx,quick-output.css):.studio-reveal-linkon the打开所在文件夹button (data-testid="reveal-in-folder-btn"preserved) and give itgrid-column: 1 / -1; order: 10;under.studio-output-card .ac-card-actionsso primary actions stay cleanly 2-up (下载成片|发布) without squeezing 3 buttons onto one row or wrapping打开所在文件夹.Verification
frontend/tests/rc159-2d37667d-regressions.test.cjsfailed before the fix and passes after.scripts/quality_gate.pypassed (tracked_changes: false, all groups green).