Skip to content

Handle macOS EINVAL when enabling TCP_NODELAY on outbound TCP sockets #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drewnoakes merged 2 commits into from
May 24, 2026
+9 −2
Merged

Handle macOS EINVAL when enabling TCP_NODELAY on outbound TCP sockets #1161

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90e3d77
Initial plan
Copilot May 24, 2026
630daeb
Handle macOS InvalidArgument from TCP NoDelay setup
Copilot May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/NetMQ/Core/Transports/Tcp/TcpConnector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,11 +236,18 @@ public void OutCompleted(SocketError socketError, int bytesTransferred)
m_ioObject.RemoveSocket(m_s);
m_handleValid = false;

try {
try
{
m_s.NoDelay = true;
} catch (ArgumentException) {
}
catch (ArgumentException)
{
// OSX sometime fail while the socket is still connecting
}
catch (SocketException ex) when (ex.SocketErrorCode == SocketError.InvalidArgument)
{
// macOS may report EINVAL here while the socket is still connecting.
}

// As long as the TCP keep-alive option is not -1 (indicating no change),
if (m_options.TcpKeepalive != -1)
Expand Down
Loading