Skip to content

Guard StreamEngine handshake against null peer identity when RecvIdentity is enabled - #1160

Merged
drewnoakes merged 6 commits into
masterfrom
copilot/fix-nullreferenceexception-streamengine
May 24, 2026
Merged

Guard StreamEngine handshake against null peer identity when RecvIdentity is enabled#1160
drewnoakes merged 6 commits into
masterfrom
copilot/fix-nullreferenceexception-streamengine

Use nullable restore, not disable

0cc9b8c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed May 24, 2026 in 1s

19.73% (-46.25%) compared to 8109871

View this Pull Request on Codecov

19.73% (-46.25%) compared to 8109871

Details

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 19.73%. Comparing base (8109871) to head (0cc9b8c).
⚠️ Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
src/NetMQ/Core/Transports/StreamEngine.cs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1160       +/-   ##
===========================================
- Coverage   65.98%   19.73%   -46.25%     
===========================================
  Files         145      148        +3     
  Lines        9149     9408      +259     
  Branches     1486     1544       +58     
===========================================
- Hits         6037     1857     -4180     
- Misses       2500     7270     +4770     
+ Partials      612      281      -331     
Files with missing lines Coverage Δ
src/NetMQ/Core/Transports/StreamEngine.cs 43.04% <0.00%> (-18.77%) ⬇️

... and 117 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.