Skip to content

chore: remove debug log and clarify max-bundle-count description - #27

Open
jhfnetboy wants to merge 1 commit into
zerodevapp:mainfrom
AAStarCommunity:upstream-pr/cleanup-debug-and-cli-description
Open

chore: remove debug log and clarify max-bundle-count description#27
jhfnetboy wants to merge 1 commit into
zerodevapp:mainfrom
AAStarCommunity:upstream-pr/cleanup-debug-and-cli-description

Conversation

@jhfnetboy

Copy link
Copy Markdown

Two minor cleanups discovered during AAStar's downstream fork acceptance review.

What

  1. Remove leftover debug console.log in eth_sendUserOperation handler
    src/rpc/methods/eth_sendUserOperation.ts:225
    console.log("=== eth_sendUserOperation called ===") was introduced in commit 702f9af (alto merge) and appears to be a debug residual. It fires on every eth_sendUserOperation call.

  2. Clarify --max-bundle-count CLI description
    src/cli/config/options.ts:103-108
    The current description says "Maximum number of UserOperations to include in a bundle", but the actual behavior (see src/mempool/mempool.ts:725-773, getBundles loop break condition bundles.length >= maxBundleCount) caps the number of bundles produced per getBundles() iteration, not the per-bundle UserOp count. The previous wording misled operators configuring the flag in our deployment.

Why upstream

Both are present in the current main HEAD and affect any downstream consumer. AAStar found these during M1 acceptance review of our fork (AAStarCommunity/UltraRelay-AAStar) and we'd like to feed them back so all downstream forks benefit.

No behavior change

  • The console.log removal is pure noise reduction.
  • The CLI description change is documentation only — no runtime behavior changes.

Test

Lint passes (pnpm run lint). No new tests needed (no behavior change).

Context

AAStar maintains a downstream fork at https://github.com/AAStarCommunity/UltraRelay-AAStar tracking ZeroDev/ultra-relay for our SuperPaymaster + xPNTs gasless infrastructure. We plan monthly upstream sync and will feed back any non-AAStar-specific improvements.

Two minor cleanups suitable for upstreaming to zerodevapp/ultra-relay:

1. Remove leftover debug console.log("=== eth_sendUserOperation called ===")
   in eth_sendUserOperation handler (introduced in commit 702f9af alto merge).

2. Fix --max-bundle-count CLI description: the flag actually caps the number
   of BUNDLES produced per getBundles() iteration (see mempool.ts:725-773),
   not the number of UserOperations within a single bundle. The previous
   wording misled operators configuring the flag.

No behavior change.

@clestons clestons left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-Review: #27 — chore: remove debug log and clarify max-bundle-count description

Verdict: APPROVE · Score: 95/100
Reviewed by: Claude Code (DeepSeek) · PK skipped (low-risk: ABI sync / docs / chore / scaffold)
No logic or security concerns found.

@clestons clestons left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PK Review — #27

Verdict: APPROVE — Pure chore: remove a leftover debug console.log and fix a misleading CLI flag description. No behavior changes.

  • eth_sendUserOperation.ts: console.log("=== eth_sendUserOperation called ===") removed — was a debug artifact from an earlier merge.
  • options.ts: --max-bundle-count description corrected — it caps bundles per getBundles() iteration, not UserOps per bundle. The previous wording would mislead operators tuning this flag.

No logic changes, no security surface. BUMP/chore track — PK not required.

@clestons clestons left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#27 Review — APPROVE

两处 chore 清理,无行为变更:

  1. 移除遗留 debug logeth_sendUserOperation.ts 删除 console.log("=== eth_sendUserOperation called ===") — 该 log 在 alto merge 时引入,在生产环境会产生大量噪音。

  2. 修正 CLI description--max-bundle-count 的 description 原文描述为"单 bundle 中的 UserOp 数量上限",实际语义是"每次 getBundles() 迭代返回的 bundle 数量上限"(mempool.ts:725-773)。修正后描述准确,防止运营人员错误配置。

CHORE-track. PK skipped — no logic change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants