chore: remove debug log and clarify max-bundle-count description - #27
Conversation
Two minor cleanups suitable for upstreaming to zerodevapp/ultra-relay:
1. Remove leftover debug console.log("=== eth_sendUserOperation called ===")
in eth_sendUserOperation handler (introduced in commit 702f9af alto merge).
2. Fix --max-bundle-count CLI description: the flag actually caps the number
of BUNDLES produced per getBundles() iteration (see mempool.ts:725-773),
not the number of UserOperations within a single bundle. The previous
wording misled operators configuring the flag.
No behavior change.
clestons
left a comment
There was a problem hiding this comment.
Auto-Review: #27 — chore: remove debug log and clarify max-bundle-count description
Verdict: APPROVE · Score: 95/100
Reviewed by: Claude Code (DeepSeek) · PK skipped (low-risk: ABI sync / docs / chore / scaffold)
No logic or security concerns found.
clestons
left a comment
There was a problem hiding this comment.
PK Review — #27
Verdict: APPROVE — Pure chore: remove a leftover debug console.log and fix a misleading CLI flag description. No behavior changes.
eth_sendUserOperation.ts:console.log("=== eth_sendUserOperation called ===")removed — was a debug artifact from an earlier merge.options.ts:--max-bundle-countdescription corrected — it caps bundles pergetBundles()iteration, not UserOps per bundle. The previous wording would mislead operators tuning this flag.
No logic changes, no security surface. BUMP/chore track — PK not required.
clestons
left a comment
There was a problem hiding this comment.
#27 Review — APPROVE
两处 chore 清理,无行为变更:
-
移除遗留 debug log:
eth_sendUserOperation.ts删除console.log("=== eth_sendUserOperation called ===")— 该 log 在 alto merge 时引入,在生产环境会产生大量噪音。 -
修正 CLI description:
--max-bundle-count的 description 原文描述为"单 bundle 中的 UserOp 数量上限",实际语义是"每次getBundles()迭代返回的 bundle 数量上限"(mempool.ts:725-773)。修正后描述准确,防止运营人员错误配置。
CHORE-track. PK skipped — no logic change.
Two minor cleanups discovered during AAStar's downstream fork acceptance review.
What
Remove leftover debug
console.logineth_sendUserOperationhandlersrc/rpc/methods/eth_sendUserOperation.ts:225—console.log("=== eth_sendUserOperation called ===")was introduced in commit702f9af(alto merge) and appears to be a debug residual. It fires on everyeth_sendUserOperationcall.Clarify
--max-bundle-countCLI descriptionsrc/cli/config/options.ts:103-108—The current description says "Maximum number of UserOperations to include in a bundle", but the actual behavior (see
src/mempool/mempool.ts:725-773,getBundlesloop break conditionbundles.length >= maxBundleCount) caps the number of bundles produced pergetBundles()iteration, not the per-bundle UserOp count. The previous wording misled operators configuring the flag in our deployment.Why upstream
Both are present in the current
mainHEAD and affect any downstream consumer. AAStar found these during M1 acceptance review of our fork (AAStarCommunity/UltraRelay-AAStar) and we'd like to feed them back so all downstream forks benefit.No behavior change
console.logremoval is pure noise reduction.Test
Lint passes (
pnpm run lint). No new tests needed (no behavior change).Context
AAStar maintains a downstream fork at https://github.com/AAStarCommunity/UltraRelay-AAStar tracking ZeroDev/ultra-relay for our SuperPaymaster + xPNTs gasless infrastructure. We plan monthly upstream sync and will feed back any non-AAStar-specific improvements.