Skip to content

Bump npm dependencies to resolve security alerts - #53

Open
Zendesk-Pooja wants to merge 2 commits into
masterfrom
fix/security-deps-compass-4447
Open

Bump npm dependencies to resolve security alerts#53
Zendesk-Pooja wants to merge 2 commits into
masterfrom
fix/security-deps-compass-4447

Conversation

@Zendesk-Pooja

@Zendesk-Pooja Zendesk-Pooja commented Aug 7, 2026

Copy link
Copy Markdown

cc: @zendesk/compass

Description

Resolves 2 open Dependabot security alerts by running npm audit fix, which bumped brace-expansion and js-yaml to patched versions across the full dependency tree. Verified via npm ls that every resolved instance — top-level and transitive — now meets the minimum patched version.

Also added js-yaml and brace-expansion as explicit entries in the existing overrides block in package.json (which already pins diff and serialize-javascript), to make the patched pin durable against a future npm install silently re-resolving to a vulnerable version. brace-expansion resolves to two different major versions in this tree — 1.1.18 at the top level, and 2.1.4 nested under mochaminimatch — so both are pinned explicitly via npm's nested-override key syntax rather than force-collapsing one onto the other.

Also checked .github/workflows/claude.yml and .github/workflows/claude-auto-review.yml for the exact string us.anthropic.claude-sonnet-4-20250514-v1:0 per the linked task — neither file exists in this repo, so no workflow changes were made.

References

Changes

  • package-lock.json: brace-expansion 1.1.13 → 1.1.18 and 2.0.3 → 2.1.4 (both ≥ 1.1.16); js-yaml 4.1.1 → 4.3.1 everywhere (≥ 4.3.0)
  • package.json: added js-yaml: ^4.3.1, brace-expansion: ^1.1.18, and a nested mocha > minimatch > brace-expansion: ^2.1.4 override, alongside the existing diff/serialize-javascript overrides
  • Workflow files: unchanged — .github/workflows/claude.yml and .github/workflows/claude-auto-review.yml do not exist in this repo; the only workflow present (.github/workflows/actions.yml) does not contain the target string

Risks

  • Low — patch-level bumps to transitive lint/test tooling dependencies (mocha, standard/eslint toolchain deps) only. No production dependencies changed (only ioredis is listed there and is untouched).
  • Rollback: revert this PR / git revert, or re-run npm install against the previous lockfile.

Test plan

  • npm audit — 0 vulnerabilities after fix (was 2 high severity)
  • npm ls brace-expansion — confirms 1.1.18 and 2.1.4 tree-wide (both ≥ 1.1.16)
  • npm ls js-yaml — confirms 4.3.1 tree-wide (≥ 4.3.0)
  • Re-verified after adding package.json overrides — versions unchanged, npm audit still 0 vulnerabilities
  • npm run lint (standard) — passes, no output
  • npm test — re-ran after the overrides change, all suites still passing with local Redis running
  • No build script exists in package.json — N/A
  • Confirmed target workflow files do not exist in this repo — no changes made, no changes needed

🤖 Generated with Claude Code

Runs npm audit fix to patch brace-expansion (>=1.1.16, GHSA-3jxr-9vmj-r5cp /
GHSA-mh99-v99m-4gvg / GHSA-rgw5-rvv9-x895) and js-yaml (>=4.3.0,
GHSA-h67p-54hq-rp68 / GHSA-52cp-r559-cp3m / GHSA-5p4m-2wfm-xmqj) across the
full dependency tree. Verified via npm ls that every resolved instance
(top-level and transitive) is patched; no package.json overrides were
required since audit fix resolved all instances.

Jira: COMPASS-4447
Follows the existing overrides pattern used for diff and
serialize-javascript. brace-expansion has two resolved major versions
in the tree (1.x top-level, 2.x nested under mocha>minimatch); pinned
each explicitly via a nested override key so both stay on their
patched version rather than relying on npm's current resolution,
which could silently regress on a future install.
@Zendesk-Pooja
Zendesk-Pooja marked this pull request as ready for review August 7, 2026 15:21
@Zendesk-Pooja
Zendesk-Pooja requested a review from a team as a code owner August 7, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant