d_a_mgameboard close to matching by Dwlee99 · Pull Request #1137 · zeldaret/tww

Dwlee99 · 2026-07-25T04:34:47Z

Got this TU close to matching but I need help with some function relocations (cXyz destructor is supposed to come after set_mtx) and .rodata. I also haven't fixed the indices for the dComIfG_getObjectRes calls on JPN or PAL since I don't have those ROMs.

decomp-dev · 2026-07-25T04:37:04Z

Report for GZLE01 (`6b91141` - `5976466`)

📈 Matched code: 72.54% (+0.07%, +5516 bytes)
📈 Matched data: 89.26% (+0.10%, +2372 bytes)

✅ 21 new matches

Unit	Item	Bytes	Before	After
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::CreateHeap()`	+1709	0.23%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`.bss`	+1660	26.56%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::_draw()`	+785	0.51%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::set_mtx()`	+769	0.52%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::_execute()`	+429	0.93%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::CursorMove()`	+368	1.08%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::MiniGameInit()`	+261	1.52%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_Create(void*)`	+256	1.54%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::set_2dposition()`	+252	1.56%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::CreateInit()`	+216	1.82%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::execGameMain()`	+101	3.85%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_Delete(void*)`	+76	5.00%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`dDlst_base_c::~dDlst_base_c()`	+72	0.00%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`cXyz::~cXyz()`	+60	0.00%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`CheckCreateHeap(fopAc_ac_c*)`	+28	12.50%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::execEndGame()`	+28	12.50%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`cLib_calcTimer<unsigned char>(unsigned char*)`	+28	0.00%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`cXyz::cXyz(const cXyz&)`	+28	0.00%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`.data`	+27	75.47%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`.ctors`	+4	0.00%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`dDlst_base_c::draw()`	+4	0.00%	100.00%

📈 3 improvements in unmatched items

Unit	Item	Bytes	Before	After
`d_a_mgameboard/d/actor/d_a_mgameboard`	`__sinit_d_a_mgameboard_cpp`	+5101	0.00%	99.79%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::MinigameMain()`	+491	0.81%	99.94%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`.rodata`	+243	0.00%	96.75%

Report for GZLJ01 (`6b91141` - `5976466`)

📈 Matched code: 70.71% (+0.04%, +3464 bytes)
📈 Matched data: 88.69% (+0.10%, +2264 bytes)

✅ 17 new matches

Unit	Item	Bytes	Before	After
`d_a_mgameboard/d/actor/d_a_mgameboard`	`.bss`	+1660	26.56%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::_draw()`	+785	0.51%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::set_mtx()`	+769	0.52%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::_execute()`	+429	0.93%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::CursorMove()`	+368	1.08%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::MiniGameInit()`	+261	1.52%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::set_2dposition()`	+252	1.56%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::CreateInit()`	+216	1.82%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::execGameMain()`	+101	3.85%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`dDlst_base_c::~dDlst_base_c()`	+72	0.00%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`cXyz::~cXyz()`	+60	0.00%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`CheckCreateHeap(fopAc_ac_c*)`	+28	12.50%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::execEndGame()`	+28	12.50%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`cLib_calcTimer<unsigned char>(unsigned char*)`	+28	0.00%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`cXyz::cXyz(const cXyz&)`	+28	0.00%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`.ctors`	+4	0.00%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`dDlst_base_c::draw()`	+4	0.00%	100.00%

📈 7 improvements in unmatched items

Unit	Item	Bytes	Before	After
`d_a_mgameboard/d/actor/d_a_mgameboard`	`__sinit_d_a_mgameboard_cpp`	+5101	0.00%	99.79%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::CreateHeap()`	+1703	0.23%	99.68%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::MinigameMain()`	+491	0.81%	99.94%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`.rodata`	+230	0.00%	94.82%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_Create(void*)`	+207	1.69%	89.66%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_Delete(void*)`	+75	5.00%	99.50%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`.data`	+17	76.92%	94.11%

Report for GZLP01 (`6b91141` - `5976466`)

📈 Matched code: 70.49% (+0.05%, +3544 bytes)
📈 Matched data: 88.03% (+0.10%, +2372 bytes)

✅ 19 new matches

Unit	Item	Bytes	Before	After
`d_a_mgameboard/d/actor/d_a_mgameboard`	`.bss`	+1660	26.56%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::_draw()`	+785	0.51%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::set_mtx()`	+769	0.52%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::_execute()`	+429	0.93%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::CursorMove()`	+368	1.08%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::MiniGameInit()`	+261	1.52%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::set_2dposition()`	+252	1.56%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::CreateInit()`	+216	1.82%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::execGameMain()`	+101	3.85%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_Delete(void*)`	+76	5.00%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`dDlst_base_c::~dDlst_base_c()`	+72	0.00%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`cXyz::~cXyz()`	+60	0.00%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`CheckCreateHeap(fopAc_ac_c*)`	+28	12.50%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::execEndGame()`	+28	12.50%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`cLib_calcTimer<unsigned char>(unsigned char*)`	+28	0.00%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`cXyz::cXyz(const cXyz&)`	+28	0.00%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`.data`	+27	75.47%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`.ctors`	+4	0.00%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`dDlst_base_c::draw()`	+4	0.00%	100.00%

📈 5 improvements in unmatched items

Unit	Item	Bytes	Before	After
`d_a_mgameboard/d/actor/d_a_mgameboard`	`__sinit_d_a_mgameboard_cpp`	+5101	0.00%	99.79%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::CreateHeap()`	+1708	0.23%	99.97%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::MinigameMain()`	+491	0.81%	99.94%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_Create(void*)`	+255	1.45%	94.13%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`.rodata`	+243	0.00%	95.95%

Report for D44J01 (`6b91141` - `5976466`)

📈 Matched code: 65.00% (+0.03%, +2724 bytes)
📈 Matched data: 85.74% (+0.10%, +2264 bytes)

✅ 14 new matches

Unit	Item	Bytes	Before	After
`d_a_mgameboard/d/actor/d_a_mgameboard`	`.bss`	+1660	26.56%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::_draw()`	+785	0.51%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::set_mtx()`	+769	0.52%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::_execute()`	+429	0.93%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::CursorMove()`	+368	1.08%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::execGameMain()`	+101	3.85%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`dDlst_base_c::~dDlst_base_c()`	+72	0.00%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`cXyz::~cXyz()`	+60	0.00%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`CheckCreateHeap(fopAc_ac_c*)`	+28	12.50%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::execEndGame()`	+28	12.50%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`cLib_calcTimer<unsigned char>(unsigned char*)`	+28	0.00%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`cXyz::cXyz(const cXyz&)`	+28	0.00%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`.ctors`	+4	0.00%	100.00%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`dDlst_base_c::draw()`	+4	0.00%	100.00%

📈 10 improvements in unmatched items

Unit	Item	Bytes	Before	After
`d_a_mgameboard/d/actor/d_a_mgameboard`	`__sinit_d_a_mgameboard_cpp`	+5101	0.00%	99.79%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::CreateHeap()`	+1704	0.23%	99.74%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::MinigameMain()`	+572	0.69%	99.94%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::MiniGameInit()`	+258	1.52%	99.24%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`.rodata`	+241	0.00%	89.37%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::CreateInit()`	+215	1.82%	99.85%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_c::set_2dposition()`	+202	1.01%	51.93%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_Create(void*)`	+148	1.69%	64.58%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`daMgBoard_Delete(void*)`	+35	6.25%	61.12%
`d_a_mgameboard/d/actor/d_a_mgameboard`	`.data`	+17	76.92%	94.11%

Dwlee99 added 23 commits July 14, 2026 01:13

CreateHeap 96.89%

74bce74

Unindent quite a bit and cleanup variables on CreateHeap

5580ff8

match CreateHeap 100%

76ff91e

match some smaller functions

398cf55

Cleanup

fb5713b

Fix checkEndGame

a381eec

match set_2dposition

18ba99f

CreateInit matching

cf4601f

MiniGameInit matched

a4078ae

set_mtx matching except regalloc

8f7e1cb

Minor changes

392c82e

Fix x y convention I think

2063800

Remove weird inline I'm not sure about

b34ea89

Remove debug map comment

b7d3eee

_execute matching except instruction offset

a704a8d

Fix type

772c78f

MiniGameMain() match except regalloc

755de38

CursorMove matching except relocations

5ecad02

Retype mBoardPosX + Y

aefbb33

daMgBoard_Create matching

11f2378

_draw matching

a75957c

format

6c6cc5e

Inlining and some easy demo fixes

b41b4df

Matching more stuff

cf24a76

Dwlee99 force-pushed the dwlee99/d_a_mgameboard branch from ff4b53a to cf24a76 Compare July 25, 2026 07:10

Dwlee99 added 4 commits July 25, 2026 14:05

Try to fix index naming for demo/usa distinction

93c16cc

Use sfx enum

0a32f5d

demo regswap fix

249a499

Another sfx enum

303d98c

Merge branch 'main' into dwlee99/d_a_mgameboard

5976466

Dwlee99 marked this pull request as ready for review August 2, 2026 03:41

Navigation Menu

Uh oh!

d_a_mgameboard close to matching - #1137

d_a_mgameboard close to matching#1137
Dwlee99 wants to merge 29 commits into
zeldaret:mainfrom
Dwlee99:dwlee99/d_a_mgameboard

Dwlee99 commented Jul 25, 2026 •

edited

Loading

Uh oh!

decomp-dev Bot commented Jul 25, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

Dwlee99 commented Jul 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

decomp-dev Bot commented Jul 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Report for GZLE01 (6b91141 - 5976466)

Report for GZLJ01 (6b91141 - 5976466)

Report for GZLP01 (6b91141 - 5976466)

Report for D44J01 (6b91141 - 5976466)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Dwlee99 commented Jul 25, 2026 •

edited

Loading

decomp-dev Bot commented Jul 25, 2026 •

edited

Loading

Report for GZLE01 (`6b91141` - `5976466`)

Report for GZLJ01 (`6b91141` - `5976466`)

Report for GZLP01 (`6b91141` - `5976466`)

Report for D44J01 (`6b91141` - `5976466`)