Match d_a_saku 100% - #1133
Open
LostGoron wants to merge 2 commits into
Open
Conversation
Ports the completed 66/66-function decompilation, including the REL hash fix, onto the current auto-generated actor skeleton. The five never-referenced static const members (m_start_alpha, m_alpha_spd, m_saku_height, m_at_cyl_src, m_max_particle_timer) must be defined between the _daSaku_execute inline body and the daSaku_Execute dispatcher so they land in .rodata at retail's exact layout; without them g_profile_SAKU shifts and the inter-module relocation in f_pc_profile_lst.rel breaks. Full GZLE01 build passes the REL hash check (416 files OK) and objdiff reports 100% for all three units. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Report for GZLE01 (61a3a0a - 4c306c0)📈 Matched code: 71.76% (+0.13%, +10028 bytes) ✅ 68 new matches
...and 38 more new matches Report for D44J01 (61a3a0a - 4c306c0)📈 Matched code: 63.97% (+0.02%, +1464 bytes) ✅ 38 new matches
...and 8 more new matches 📈 28 improvements in unmatched items
Report for GZLP01 (61a3a0a - 4c306c0)📈 Matched code: 69.92% (+0.13%, +10028 bytes) ✅ 68 new matches
...and 38 more new matches Report for GZLJ01 (61a3a0a - 4c306c0)📈 Matched code: 69.96% (+0.12%, +9540 bytes) ✅ 67 new matches
...and 37 more new matches 📈 1 improvement in an unmatched item
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
71/71 functions. 100% (GZLE01)