Match d_a_obj_light - #1130
Open
LostGoron wants to merge 2 commits into
Open
Conversation
Ports the completed decompilation onto the current auto-generated actor skeleton. Besides the actor TU, one shared function living in the DOL static file (daObjLight::Act_c::set_light_dif_angle_FRRS in d_com_static.cpp) had to be switched from BOOL to bool to match its header declaration. Full GZLE01 build passes the hash check (416 files OK) and objdiff reports 100% for all light units plus d_com_static. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Open
Report for GZLJ01 (61a3a0a - 6f7a9fd)📈 Matched code: 69.91% (+0.07%, +5428 bytes) ✅ 45 new matches
...and 15 more new matches Report for D44J01 (61a3a0a - 6f7a9fd)📈 Matched code: 64.00% (+0.05%, +3660 bytes) ✅ 37 new matches
...and 7 more new matches 📈 8 improvements in unmatched items
Report for GZLP01 (61a3a0a - 6f7a9fd)📈 Matched code: 69.86% (+0.07%, +5432 bytes) ✅ 45 new matches
...and 15 more new matches Report for GZLE01 (61a3a0a - 6f7a9fd)📈 Matched code: 71.71% (+0.07%, +5432 bytes) ✅ 45 new matches
...and 15 more new matches |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
47/47 functions. 100% (GZLE01).