JaiSeMgr by tommaso-perondi · Pull Request #1106 · zeldaret/tww

tommaso-perondi · 2026-07-05T22:26:17Z

Not 100% match, regalloc issues.

* matching * cleanup * d_a_npc_tt matching outside of _create and rodata * matching * cleanup

closes zeldaret#1026 closes zeldaret#1011

* d_a_npc_mt 100% for GZLE01 * implemented dPb_erasePicture and added some relevant inlines * fixed existing references to mSelectPicture * PR changes made

closes zeldaret#348

Will handle the large data arrays separately

decomp-dev · 2026-07-05T22:28:31Z

Report for D44J01 (`87b5061` - `b9e6658`)

📈 Matched code: 63.43% (+0.05%, +3672 bytes)
📉 Matched data: 84.28% (-0.07%, -1688 bytes)

✅ 16 new matches

Unit	Item	Bytes	Before	After
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::releaseSeRegist(JAISound*)`	+288	1.37%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::checkPlayingSeUpdateAddition(JAISound, JAInter::SeqUpdateData, float, JAInter::MoveParaSet, unsigned char, float*, float)`	+280	1.41%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::checkPlayingSeUpdateMultiplication(JAISound, JAInter::SeqUpdateData, float, JAInter::MoveParaSet, float, unsigned char, float*)`	+241	1.64%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::setSeqMuteFromSeStart(JAISound*)`	+209	1.89%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::clearSeqMuteFromSeStop(JAISound*)`	+205	1.92%	100.00%
`framework/JSystem/JAudio/JAISound`	`JAInter::MoveParaSet::set(float, unsigned long)`	+173	2.27%	100.00%
`framework/JSystem/JAudio/JAISequenceMgr`	`JAInter::SequenceMgr::checkFadeoutSeq()`	+165	2.38%	100.00%
`framework/JSystem/JAudio/JAISequenceMgr`	`JAInter::SequenceMgr::checkStoppedSeq()`	+156	2.50%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::releaseSeParameterPointer(JAInter::SeParameter*)`	+120	3.23%	100.00%
`framework/JSystem/JAudio/JAISound`	`JAISound::checkSoundHandle(unsigned long, void*)`	+109	3.57%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::getSeParametermeterPointer()`	+89	4.35%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::releaseSeBuffer(JAISound*, unsigned long)`	+85	4.55%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`.sdata2`	+59	27.27%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::init()`	+15	99.49%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::checkSeMovePara()`	+5	98.47%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::changeIDToCategory(unsigned long)`	+4	50.00%	100.00%

🥀 3 broken matches

Unit	Item	Bytes	Before	After
`framework/JSystem/JAudio/JAISound`	`.rodata`	-1	100.00%	99.94%
`framework/JSystem/JAudio/JAISound`	`JAISound::setPauseMode(unsigned char, unsigned char)`	-1	100.00%	99.99%
`framework/JSystem/JAudio/JAISound`	`JAInter::LinkSound::init(JAISound*, unsigned long)`	-1	100.00%	99.93%

📈 5 improvements in unmatched items

Unit	Item	Bytes	Before	After
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::checkNextFrameSe()`	+1869	0.21%	99.37%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::checkPlayingSe()`	+1337	0.30%	99.20%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::storeSeBuffer(JAISound*, JAInter::Actor, unsigned long, unsigned long, unsigned char, void*)`	+1182	0.33%	99.13%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::sendSeAllParameter(JAISound*)`	+338	1.15%	98.05%
`framework/JSystem/JAudio/JAISequenceMgr`	`JAInter::SequenceMgr::checkPlayingSeq()`	+251	1.56%	99.84%

Report for GZLE01 (`87b5061` - `b9e6658`)

📈 Matched code: 71.09% (+0.05%, +3672 bytes)
📉 Matched data: 87.84% (-0.07%, -1688 bytes)

✅ 16 new matches

Unit	Item	Bytes	Before	After
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::releaseSeRegist(JAISound*)`	+288	1.37%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::checkPlayingSeUpdateAddition(JAISound, JAInter::SeqUpdateData, float, JAInter::MoveParaSet, unsigned char, float*, float)`	+280	1.41%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::checkPlayingSeUpdateMultiplication(JAISound, JAInter::SeqUpdateData, float, JAInter::MoveParaSet, float, unsigned char, float*)`	+241	1.64%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::setSeqMuteFromSeStart(JAISound*)`	+209	1.89%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::clearSeqMuteFromSeStop(JAISound*)`	+205	1.92%	100.00%
`framework/JSystem/JAudio/JAISound`	`JAInter::MoveParaSet::set(float, unsigned long)`	+173	2.27%	100.00%
`framework/JSystem/JAudio/JAISequenceMgr`	`JAInter::SequenceMgr::checkFadeoutSeq()`	+165	2.38%	100.00%
`framework/JSystem/JAudio/JAISequenceMgr`	`JAInter::SequenceMgr::checkStoppedSeq()`	+156	2.50%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::releaseSeParameterPointer(JAInter::SeParameter*)`	+120	3.23%	100.00%
`framework/JSystem/JAudio/JAISound`	`JAISound::checkSoundHandle(unsigned long, void*)`	+109	3.57%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::getSeParametermeterPointer()`	+89	4.35%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::releaseSeBuffer(JAISound*, unsigned long)`	+85	4.55%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`.sdata2`	+59	27.27%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::init()`	+15	99.49%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::checkSeMovePara()`	+5	98.47%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::changeIDToCategory(unsigned long)`	+4	50.00%	100.00%

🥀 3 broken matches

Unit	Item	Bytes	Before	After
`framework/JSystem/JAudio/JAISound`	`.rodata`	-1	100.00%	99.94%
`framework/JSystem/JAudio/JAISound`	`JAISound::setPauseMode(unsigned char, unsigned char)`	-1	100.00%	99.99%
`framework/JSystem/JAudio/JAISound`	`JAInter::LinkSound::init(JAISound*, unsigned long)`	-1	100.00%	99.93%

📈 5 improvements in unmatched items

Unit	Item	Bytes	Before	After
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::checkNextFrameSe()`	+1884	0.21%	99.82%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::checkPlayingSe()`	+1337	0.30%	99.20%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::storeSeBuffer(JAISound*, JAInter::Actor, unsigned long, unsigned long, unsigned char, void*)`	+1182	0.33%	99.13%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::sendSeAllParameter(JAISound*)`	+338	1.15%	98.05%
`framework/JSystem/JAudio/JAISequenceMgr`	`JAInter::SequenceMgr::checkPlayingSeq()`	+251	1.56%	99.84%

Report for GZLP01 (`87b5061` - `b9e6658`)

📈 Matched code: 69.24% (+0.05%, +3672 bytes)
📉 Matched data: 86.62% (-0.07%, -1688 bytes)

✅ 16 new matches

Unit	Item	Bytes	Before	After
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::releaseSeRegist(JAISound*)`	+288	1.37%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::checkPlayingSeUpdateAddition(JAISound, JAInter::SeqUpdateData, float, JAInter::MoveParaSet, unsigned char, float*, float)`	+280	1.41%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::checkPlayingSeUpdateMultiplication(JAISound, JAInter::SeqUpdateData, float, JAInter::MoveParaSet, float, unsigned char, float*)`	+241	1.64%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::setSeqMuteFromSeStart(JAISound*)`	+209	1.89%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::clearSeqMuteFromSeStop(JAISound*)`	+205	1.92%	100.00%
`framework/JSystem/JAudio/JAISound`	`JAInter::MoveParaSet::set(float, unsigned long)`	+173	2.27%	100.00%
`framework/JSystem/JAudio/JAISequenceMgr`	`JAInter::SequenceMgr::checkFadeoutSeq()`	+165	2.38%	100.00%
`framework/JSystem/JAudio/JAISequenceMgr`	`JAInter::SequenceMgr::checkStoppedSeq()`	+156	2.50%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::releaseSeParameterPointer(JAInter::SeParameter*)`	+120	3.23%	100.00%
`framework/JSystem/JAudio/JAISound`	`JAISound::checkSoundHandle(unsigned long, void*)`	+109	3.57%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::getSeParametermeterPointer()`	+89	4.35%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::releaseSeBuffer(JAISound*, unsigned long)`	+85	4.55%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`.sdata2`	+59	27.27%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::init()`	+15	99.49%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::checkSeMovePara()`	+5	98.47%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::changeIDToCategory(unsigned long)`	+4	50.00%	100.00%

🥀 3 broken matches

Unit	Item	Bytes	Before	After
`framework/JSystem/JAudio/JAISound`	`.rodata`	-1	100.00%	99.94%
`framework/JSystem/JAudio/JAISound`	`JAISound::setPauseMode(unsigned char, unsigned char)`	-1	100.00%	99.99%
`framework/JSystem/JAudio/JAISound`	`JAInter::LinkSound::init(JAISound*, unsigned long)`	-1	100.00%	99.93%

📈 5 improvements in unmatched items

Unit	Item	Bytes	Before	After
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::checkNextFrameSe()`	+1884	0.21%	99.82%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::checkPlayingSe()`	+1337	0.30%	99.20%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::storeSeBuffer(JAISound*, JAInter::Actor, unsigned long, unsigned long, unsigned char, void*)`	+1182	0.33%	99.13%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::sendSeAllParameter(JAISound*)`	+338	1.15%	98.05%
`framework/JSystem/JAudio/JAISequenceMgr`	`JAInter::SequenceMgr::checkPlayingSeq()`	+251	1.56%	99.84%

Report for GZLJ01 (`87b5061` - `b9e6658`)

📈 Matched code: 69.28% (+0.05%, +3672 bytes)
📉 Matched data: 87.26% (-0.07%, -1688 bytes)

✅ 16 new matches

Unit	Item	Bytes	Before	After
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::releaseSeRegist(JAISound*)`	+288	1.37%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::checkPlayingSeUpdateAddition(JAISound, JAInter::SeqUpdateData, float, JAInter::MoveParaSet, unsigned char, float*, float)`	+280	1.41%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::checkPlayingSeUpdateMultiplication(JAISound, JAInter::SeqUpdateData, float, JAInter::MoveParaSet, float, unsigned char, float*)`	+241	1.64%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::setSeqMuteFromSeStart(JAISound*)`	+209	1.89%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::clearSeqMuteFromSeStop(JAISound*)`	+205	1.92%	100.00%
`framework/JSystem/JAudio/JAISound`	`JAInter::MoveParaSet::set(float, unsigned long)`	+173	2.27%	100.00%
`framework/JSystem/JAudio/JAISequenceMgr`	`JAInter::SequenceMgr::checkFadeoutSeq()`	+165	2.38%	100.00%
`framework/JSystem/JAudio/JAISequenceMgr`	`JAInter::SequenceMgr::checkStoppedSeq()`	+156	2.50%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::releaseSeParameterPointer(JAInter::SeParameter*)`	+120	3.23%	100.00%
`framework/JSystem/JAudio/JAISound`	`JAISound::checkSoundHandle(unsigned long, void*)`	+109	3.57%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::getSeParametermeterPointer()`	+89	4.35%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::releaseSeBuffer(JAISound*, unsigned long)`	+85	4.55%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`.sdata2`	+59	27.27%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::init()`	+15	99.49%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::checkSeMovePara()`	+5	98.47%	100.00%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::changeIDToCategory(unsigned long)`	+4	50.00%	100.00%

🥀 3 broken matches

Unit	Item	Bytes	Before	After
`framework/JSystem/JAudio/JAISound`	`.rodata`	-1	100.00%	99.94%
`framework/JSystem/JAudio/JAISound`	`JAISound::setPauseMode(unsigned char, unsigned char)`	-1	100.00%	99.99%
`framework/JSystem/JAudio/JAISound`	`JAInter::LinkSound::init(JAISound*, unsigned long)`	-1	100.00%	99.93%

📈 5 improvements in unmatched items

Unit	Item	Bytes	Before	After
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::checkNextFrameSe()`	+1884	0.21%	99.82%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::checkPlayingSe()`	+1337	0.30%	99.20%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::storeSeBuffer(JAISound*, JAInter::Actor, unsigned long, unsigned long, unsigned char, void*)`	+1182	0.33%	99.13%
`framework/JSystem/JAudio/JAISeMgr`	`JAInter::SeMgr::sendSeAllParameter(JAISound*)`	+338	1.15%	98.05%
`framework/JSystem/JAudio/JAISequenceMgr`	`JAInter::SequenceMgr::checkPlayingSeq()`	+251	1.56%	99.84%

Tommaso Perondi and others added 12 commits July 5, 2026 14:17

JAISeMgr: almost complete, non linking, high match

01528bf

JAISeMgr: little progress, regalloc issues

42211db

JAISeMgr: progress but regalloc issues

36be3c0

removed non matching from 100% methods

8af8413

D_a_npc_tt (zeldaret#1099)

a08b9fa

* matching * cleanup * d_a_npc_tt matching outside of _create and rodata * matching * cleanup

d_menu_save mostly done (zeldaret#1103)

ee4c5a6

d_menu_save OK

1923bfd

closes zeldaret#1026 closes zeldaret#1011

d_a_npc_mt 100% for GZLE01 (zeldaret#1102)

7a41a47

* d_a_npc_mt 100% for GZLE01 * implemented dPb_erasePicture and added some relevant inlines * fixed existing references to mSelectPicture * PR changes made

d_a_npc_mt OK for all versions

6f8ff44

closes zeldaret#348

d_flower Code Matching (zeldaret#1105)

af12518

Will handle the large data arrays separately

Match most d_flower funcs for demo

68fc1ae

Remove Matching

b9e6658

Navigation Menu

Uh oh!

JaiSeMgr - #1106

JaiSeMgr#1106
tommaso-perondi wants to merge 12 commits into
zeldaret:mainfrom
tommaso-perondi:JaiSeMgr

tommaso-perondi commented Jul 5, 2026

Uh oh!

decomp-dev Bot commented Jul 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

tommaso-perondi commented Jul 5, 2026

Uh oh!

decomp-dev Bot commented Jul 5, 2026

Report for D44J01 (87b5061 - b9e6658)

Report for GZLE01 (87b5061 - b9e6658)

Report for GZLP01 (87b5061 - b9e6658)

Report for GZLJ01 (87b5061 - b9e6658)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Report for D44J01 (`87b5061` - `b9e6658`)

Report for GZLE01 (`87b5061` - `b9e6658`)

Report for GZLP01 (`87b5061` - `b9e6658`)

Report for GZLJ01 (`87b5061` - `b9e6658`)