DaObjVds retail - #1104
Open
Azurpourpre wants to merge 38 commits into
Open
Conversation
Report for GZLE01 (87b5061 - 7e4ff0d)📈 Matched code: 71.11% (+0.07%, +5676 bytes) ✅ 34 new matches
...and 4 more new matches Report for GZLJ01 (87b5061 - 7e4ff0d)📈 Matched code: 69.31% (+0.07%, +5676 bytes) ✅ 34 new matches
...and 4 more new matches Report for GZLP01 (87b5061 - 7e4ff0d)📈 Matched code: 69.26% (+0.07%, +5676 bytes) ✅ 34 new matches
...and 4 more new matches Report for D44J01 (87b5061 - 7e4ff0d)📈 Matched code: 63.44% (+0.06%, +4808 bytes) ✅ 31 new matches
...and 1 more new matches 📈 3 improvements in unmatched items
|
WilliamArnett
suggested changes
Jul 5, 2026
WilliamArnett
left a comment
WilliamArnett
left a comment
Contributor
There was a problem hiding this comment.
Hi Azur. This should cause the TU to match for retail builds.
| void daObjVds::Act_c::search_switchCB(fopAc_ac_c*) { | ||
| /* Nonmatching */ | ||
| void* daObjVds::Act_c::search_switchCB(fopAc_ac_c* i_actor) { | ||
| if(fopAc_IsActor(i_actor) && fopAcM_GetName(i_actor) == fpcNm_Obj_Swlight_e){ |
Contributor
There was a problem hiding this comment.
Suggested change
| if(fopAc_IsActor(i_actor) && fopAcM_GetName(i_actor) == fpcNm_Obj_Swlight_e){ | |
| cXyz unused; | |
| if(fopAc_IsActor(i_actor) && fopAcM_GetName(i_actor) == fpcNm_Obj_Swlight_e){ |
Contributor
Author
|
Got it matching for retail (GZLE01, GZLJ01, GZLP01). D44J01 has a regalloc issue in daObjVds::Act_c::process_common |
Azurpourpre
marked this pull request as ready for review
July 8, 2026 15:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#371
Currently, TU is matching in objdiff but not after linking. There is also a regalloc issue in demo.