Skip to content

d_a_obj_msdan2 - 100% matching for GZLJ01, GZLE01 and GZLP01 - #1092

Open
samkleespies wants to merge 2 commits into
zeldaret:mainfrom
samkleespies:d_a_obj_msdan2
Open

d_a_obj_msdan2 - 100% matching for GZLJ01, GZLE01 and GZLP01#1092
samkleespies wants to merge 2 commits into
zeldaret:mainfrom
samkleespies:d_a_obj_msdan2

Conversation

@samkleespies

Copy link
Copy Markdown

Fully matches d_a_obj_msdan2.

  • Mthd_Create: spawns 16 MsdanSub2 child actors along the actor's facing with rotating orientation, registers the Msdan2 event, and initialises the state from the save switch.
  • Mthd_Execute: switch-save / event state machine.
  • Mthd_Delete: stub.

REL is byte-identical for GZLE01; CI covers GZLJ01/GZLP01.

@decomp-dev

decomp-dev Bot commented Jul 1, 2026

Copy link
Copy Markdown

Report for GZLJ01 (873bb82 - 0e34ecf)

📈 Matched code: 68.45% (+0.01%, +752 bytes)
📈 Linked code: 55.91% (+0.01%, +864 bytes)
📈 Matched data: 87.10% (+0.00%, +95 bytes)
📈 Linked data: 46.94% (+0.00%, +95 bytes)

✅ 6 new matches
Unit Item Bytes Before After
d_a_obj_msdan2/d/actor/d_a_obj_msdan2 daObjMsdan2::Act_c::Mthd_Create() +464 0.85% 100.00%
d_a_obj_msdan2/d/actor/d_a_obj_msdan2 daObjMsdan2::Act_c::Mthd_Execute() +244 1.61% 100.00%
d_a_obj_msdan2/d/actor/d_a_obj_msdan2 daObj::PrmAbstract<daObjMsdan2::Act_c::Prm_e>(const fopAc_ac_c*, daObjMsdan2::Act_c::Prm_e, daObjMsdan2::Act_c::Prm_e) +28 0.00% 100.00%
d_a_obj_msdan2/d/actor/d_a_obj_msdan2 .rodata +15 0.00% 100.00%
d_a_obj_msdan2/d/actor/d_a_obj_msdan2 daObjMsdan2::Act_c::Mthd_Delete() +4 50.00% 100.00%
d_a_obj_msdan2/d/actor/d_a_obj_msdan2 .data +1 99.00% 100.00%

Report for GZLP01 (873bb82 - 0e34ecf)

📈 Matched code: 68.41% (+0.01%, +752 bytes)
📈 Linked code: 55.39% (+0.01%, +864 bytes)
📈 Matched data: 86.43% (+0.00%, +95 bytes)
📈 Linked data: 47.82% (+0.00%, +95 bytes)

✅ 6 new matches
Unit Item Bytes Before After
d_a_obj_msdan2/d/actor/d_a_obj_msdan2 daObjMsdan2::Act_c::Mthd_Create() +464 0.85% 100.00%
d_a_obj_msdan2/d/actor/d_a_obj_msdan2 daObjMsdan2::Act_c::Mthd_Execute() +244 1.61% 100.00%
d_a_obj_msdan2/d/actor/d_a_obj_msdan2 daObj::PrmAbstract<daObjMsdan2::Act_c::Prm_e>(const fopAc_ac_c*, daObjMsdan2::Act_c::Prm_e, daObjMsdan2::Act_c::Prm_e) +28 0.00% 100.00%
d_a_obj_msdan2/d/actor/d_a_obj_msdan2 .rodata +15 0.00% 100.00%
d_a_obj_msdan2/d/actor/d_a_obj_msdan2 daObjMsdan2::Act_c::Mthd_Delete() +4 50.00% 100.00%
d_a_obj_msdan2/d/actor/d_a_obj_msdan2 .data +1 99.00% 100.00%

Report for D44J01 (873bb82 - 0e34ecf)

📈 Matched code: 62.62% (+0.01%, +752 bytes)
📈 Matched data: 84.12% (+0.00%, +95 bytes)

✅ 6 new matches
Unit Item Bytes Before After
d_a_obj_msdan2/d/actor/d_a_obj_msdan2 daObjMsdan2::Act_c::Mthd_Create() +464 0.85% 100.00%
d_a_obj_msdan2/d/actor/d_a_obj_msdan2 daObjMsdan2::Act_c::Mthd_Execute() +244 1.61% 100.00%
d_a_obj_msdan2/d/actor/d_a_obj_msdan2 daObj::PrmAbstract<daObjMsdan2::Act_c::Prm_e>(const fopAc_ac_c*, daObjMsdan2::Act_c::Prm_e, daObjMsdan2::Act_c::Prm_e) +28 0.00% 100.00%
d_a_obj_msdan2/d/actor/d_a_obj_msdan2 .rodata +15 0.00% 100.00%
d_a_obj_msdan2/d/actor/d_a_obj_msdan2 daObjMsdan2::Act_c::Mthd_Delete() +4 50.00% 100.00%
d_a_obj_msdan2/d/actor/d_a_obj_msdan2 .data +1 99.00% 100.00%

Report for GZLE01 (873bb82 - 0e34ecf)

📈 Matched code: 70.24% (+0.01%, +752 bytes)
📈 Linked code: 57.27% (+0.01%, +864 bytes)
📈 Matched data: 87.64% (+0.00%, +95 bytes)
📈 Linked data: 48.20% (+0.00%, +95 bytes)

✅ 6 new matches
Unit Item Bytes Before After
d_a_obj_msdan2/d/actor/d_a_obj_msdan2 daObjMsdan2::Act_c::Mthd_Create() +464 0.85% 100.00%
d_a_obj_msdan2/d/actor/d_a_obj_msdan2 daObjMsdan2::Act_c::Mthd_Execute() +244 1.61% 100.00%
d_a_obj_msdan2/d/actor/d_a_obj_msdan2 daObj::PrmAbstract<daObjMsdan2::Act_c::Prm_e>(const fopAc_ac_c*, daObjMsdan2::Act_c::Prm_e, daObjMsdan2::Act_c::Prm_e) +28 0.00% 100.00%
d_a_obj_msdan2/d/actor/d_a_obj_msdan2 .rodata +15 0.00% 100.00%
d_a_obj_msdan2/d/actor/d_a_obj_msdan2 daObjMsdan2::Act_c::Mthd_Delete() +4 50.00% 100.00%
d_a_obj_msdan2/d/actor/d_a_obj_msdan2 .data +1 99.00% 100.00%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant