Port docs from PH - #90
Conversation
Yanis002
left a comment
Yanis002
left a comment
There was a problem hiding this comment.
I started the review thinking it was ready and just as I'm about to be done I notice the draft lol (no worries it's a me issue), anyway here's my comments for now, feel free if you have any questions
| 1. Press the `decomp.me` button in `objdiff`. | ||
| 1. Once you're sent to `decomp.me`, go to "Options" and change the preset to "Phantom Hourglass". | ||
| 1. Paste your code into the "Source code" tab. | ||
| 1. Share the link with us! |
There was a problem hiding this comment.
| 1. Share the link with us! | |
| 1. Share the link with us! | |
| Note: if the function is using THUMB mode you can use `THUMB_BEGIN` and `THUMB_END` before and after the function to create a THUMB region, anything outside of the region will use ARM. |
There was a problem hiding this comment.
oh yeah also, as I learned yesterday, if you have inlines in a header and #include the header outside of the region it will use ARM, but if you do include it inside the thumb region it will use thumb
There was a problem hiding this comment.
oh yeah also, as I learned yesterday, if you have inlines in a header and #include the header outside of the region it will use ARM, but if you do include it inside the thumb region it will use thumb
I tried to include that in the description if that's what you wanted, let me know how it works for you
|
|
||
| Another consequence of having a destructor is that a `DestructorChain` object will be added to the `.bss` section. This struct | ||
| is 12 (`0xc`) bytes long and is also implicit, so we don't need to define it ourselves. | ||
|
|
There was a problem hiding this comment.
to this I'd like to add that if you have multiple ctors in the same file they will all end up in the same static initializer function, meaning the order of the declarations will change the order of the code from the sinit function (also something else to know is that you only have one sinit per source file)
There was a problem hiding this comment.
I'm unsure how to formulate that since I don't fully understand what is going on, I'll leave that small comment to you if you have time
Co-authored-by: Yanis <35189056+Yanis002@users.noreply.github.com>
Co-authored-by: Yanis <35189056+Yanis002@users.noreply.github.com> Done manually because I screwed-up on github
|
I'm putting this as ready mainly because I think it needs a review, maybe the merge can be delayed even once reviewed if there is more to do. |
2 participants
No description provided.