spec: implement skip_duplicate_include for explicit skips, add error otherwise - #2790
Open
Dragorn421 wants to merge 7 commits into
Open
spec: implement skip_duplicate_include for explicit skips, add error otherwise#2790Dragorn421 wants to merge 7 commits into
skip_duplicate_include for explicit skips, add error otherwise#2790Dragorn421 wants to merge 7 commits into
Conversation
…cludes (otherwise by default, error in mkldscript)
Dragorn421
marked this pull request as ready for review
August 3, 2026 14:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds upon #2777
This adds a top-level (outside segments) directive to the spec
skip_duplicate_includeThis directive indicates which includes should be ignored if encountered more than once.
If a file is included more than once but isn't marked with
skip_duplicate_include, it will appear several times and mkldscript will error when processing the spec (added in this PR too).