Fixed Dockerfile. - #1882
Open
Zeri-Ai wants to merge 4 commits into
Open
Conversation
Dockerfile updated per the file on https://practicerom.com/public/packages/debian/howto.txt and Debian/Ubuntu's apt-key command being deprecated.
hensldm
added
Tooling
Needs-second-approval
hensldm
reviewed
Aug 1, 2026
hensldm
reviewed
Aug 2, 2026
Comment on lines
+29
to
+31
| RUN curl -O https://practicerom.com/public/packages/debian/dists/stable/practicerom-repository_latest_$(dpkg --print-architecture).deb && \ | ||
| dpkg -i practicerom-repository_latest_$(dpkg --print-architecture).deb && \ | ||
| apt update |
Collaborator
There was a problem hiding this comment.
This needs to back up before the Install Required Dependencies.
Basically all you need to do is replace the
curl -o /usr/share/keyrings/practicerom-archive-keyring.gpg https://practicerom.com/public/packages/debian/practicerom-archive-keyring.gpg && \
echo 'deb [arch=all,amd64 signed-by=/usr/share/keyrings/practicerom-archive-keyring.gpg] http://practicerom.com/public/packages/debian unstable main' > /etc/apt/sources.list.d/practicerom.listwith the new
curl -O https://practicerom.com/public/packages/debian/dists/stable/practicerom-repository_latest_$(dpkg --print-architecture).deb && \
dpkg -i practicerom-repository_latest_$(dpkg --print-architecture).debYou will still need to sudo apt install practicerom-dev like it was doing before.
Also could you add a comment with a link to the PracticeRom packages Readme for future reference of the instructions.
Author
There was a problem hiding this comment.
Thank you for your guidance!
I modified the Dockerfile per your indications.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dockerfile updated per the file on https://practicerom.com/public/packages/debian/howto.txt and Debian/Ubuntu's apt-key command being deprecated.