[n64-jp-1.1] libu64/gfxprint - #1874
Open
hensldm wants to merge 1 commit into
Open
Conversation
hensldm
added
boot
Needs-second-approval
AngheloAlf
reviewed
Apr 26, 2026
Comment on lines
+12
to
+18
| #if MM_VERSION < N64_US || DEBUG_FEATURES | ||
| #define GFXPRINT_PRINTF osSyncPrintf | ||
| #elif IDO_PRINTF_WORKAROUND | ||
| #define GFXPRINT_PRINTF(args) (void)0 | ||
| #else | ||
| #define GFXPRINT_PRINTF(format, ...) (void)0 | ||
| #endif |
Collaborator
There was a problem hiding this comment.
This seems to be becoming a pattern. Maybe we should move this to a header?
Collaborator
Author
There was a problem hiding this comment.
I wouldn't be opposed, though will admit not quite sure what to call it so as to not conflict with the original PRINTF that keeps the strings, but not the osSyncPrintf call. Would you have any suggestion?
AngheloAlf
approved these changes
May 28, 2026
AngheloAlf
left a comment
AngheloAlf
left a comment
Collaborator
There was a problem hiding this comment.
I don't have any.
I guess we can worry about it later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.