[Neverlord]

Fix remaining clang-tidy findings and re-enable on CI (by fixing the path to the sources in ci/analyze.sh).

[Copilot]

Pull request overview

This PR addresses remaining clang-tidy findings and re-enables the CI clang-tidy job by fixing the source path in ci/analyze.sh.

Changes:

• Update tests and small library code paths to satisfy clang-tidy (e.g., optional checks, tuple utilities, iterator arithmetic).
• Add/adjust clang-tidy suppressions/configuration and a small API addition (expected::has_value()).
• Fix CI clang-tidy invocation path; add a Rocky 8 CI Dockerfile.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
libbroker/broker/topic.hh	Adds targeted NOLINT suppression around topic::compare.
libbroker/broker/status.test.cc	Reworks optional/context assertions to avoid dereference and satisfy clang-tidy.
libbroker/broker/peering.test.cc	Tweaks macro helper lambda parameter passing to reduce copies / satisfy checks.
libbroker/broker/logger.cc	Switches locking primitive to std::scoped_lock.
libbroker/broker/internal/type_id.hh	Removes broad NOLINT suppression around an atom-alias macro.
libbroker/broker/internal/channel.test.cc	Fixes numeric conversions/iterator arithmetic flagged by clang-tidy.
libbroker/broker/hub.test.cc	Updates optional handling in subscriber tests (introduces a logic issue).
libbroker/broker/expected.hh	Adds has_value() convenience observer.
libbroker/broker/error.test.cc	Reworks optional/context access patterns similarly to other tests.
libbroker/broker/data.test.cc	Adds explanation for redundant CHECK(opt) && opt pattern; updates tests accordingly.
libbroker/broker/builder.hh	Uses std::tuple_size_v to satisfy modern C++ style checks.
libbroker/broker/alm/routing_table.test.cc	Removes unused variable; makes loop variable const-ref.
libbroker/broker/alm/multipath.test.cc	Removes unused variable; adds an extra comparison check; makes loop variable const-ref.
libbroker/broker/address.cc	Refactors helper into anonymous namespace and simplifies bit math.
ci/rocky-8/Dockerfile	Adds new Rocky 8 build image definition.
ci/analyze.sh	Updates run-clang-tidy target path to $PWD/libbroker.
.clang-tidy	Disables additional checks to reduce findings/noise.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.