[TESTING] Canary the ynab-sast-scanner migration - #60
Closed
sgrammargs wants to merge 1 commit into
Closed
Conversation
Points this repo's Socket Basics workflow at the unmerged ynab-sast-scanner and ynab-sast-scanner-suppressions branches, and adds a fixture with a real, unsuppressed finding (TLS verification disabled on an outbound request) to confirm the new workflow actually fails a PR check, not just that it runs. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
github-actions
Bot
added
the
security: critical
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing only — not to be merged.
Points this repo's
socket-basics.ymlat the unmergedynab-sast-scannerandynab-sast-scanner-suppressionsbranches (add-sast-scanner-infrastructure) and addssast-canary/canary.py, which has one deliberate, unsuppressed finding (TLS verification disabled on an outbound request — critical + high). This confirms the new workflow doesn't just run, but actually fails a PR check on a real finding, the same way the currentshared-actions-based workflow does today.No fix will be pushed here — this PR is meant to sit red.