fix: canonicalize indexed database query parameters#4120
Draft
astandrik wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
utm_referrer, and avoid dangling delimitersRoot cause
qs.parseconverts repeated or indexed query keys into arrays or objects. The link-generation and unknown-parameter restoration paths serialized those structures without first collapsing known scalar UI state, allowing corrupted database URLs to retain or introduce multiple values and numeric bracket keys.Impact
Existing corrupted URLs are canonicalized on the next generated link or URL-backed state change. The last scalar value wins, while unlisted multi-value parameters remain multi-valued. This does not add a startup redirect or change the public top-level API.
Validation
npm test -- src/store/__test__/state-url-mapping.test.ts src/routes.test.ts --runInBand --no-cachenpm run typechecknpm run lintnpm test— 123 suites, 1247 testsnpm run packageFixes #4119
CI Results
Test Status: ❌ FAILED
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: 🔺
Current: 64.41 MB | Main: 64.41 MB
Diff: +5.50 KB (0.01%)
ℹ️ CI Information