fix(fslib): invalidate stale archive mounts - #7244
Open
cyphercodes wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Fixes #7241.
MountFScould keep treating a path as an archive after the archive file had been replaced by a directory at the same path. Follow-up reads below that path then tried to reopen the directory as a zip archive and threwEISDIRinstead of falling back to the base filesystem.How did you fix it?
findMountnow revalidates cached mount paths against the configuredtypeCheck. If a cached archive path no longer has the expected type, the stale cached mount is discarded and the path is remembered as a non-mount so the base filesystem handles it.I also added a regression test that first reads from a custom-extension archive, then replaces that archive path with a directory and reads the directory file through the same
ZipOpenFSinstance.Checklist
Tests: