stress: stop watchers on closed channels - #2069
Open
vividvisit wants to merge 1 commit into
Open
vividvisit wants to merge 1 commit into
vividvisit wants to merge 1 commit into
Conversation
Signed-off-by: vividvisit <vividvisit@outlook.com>
Summary by OctaneAdds closed-channel detection to the two receive loops in pkg/stress/watcher.go so each goroutine returns instead of spinning on a closed channel. Changes
🔗 Commit Hash: c773996 |
OverviewOctane AI analysis has finished. No vulnerabilities were found. Cheers! 🎉🎉🎉 🔗 Commit Hash: c773996 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop the stress watcher when either upstream subscription channel closes.
Receiving from a closed channel succeeds immediately with a zero value, so the existing select loop can spin indefinitely and process misleading events. Check the receive boolean, return cleanly, and cover both channel-closure paths.