Skip to content

dont crash if 0 args provided when x_payload_raw is set #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mahad-10 merged 1 commit into from
Aug 26, 2025
Merged

dont crash if 0 args provided when x_payload_raw is set #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 21 additions & 6 deletions xconn/session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,15 +196,30 @@ def call(self, procedure: str, *args, **kwargs) -> types.Result:
options: dict[str, None] | None = kwargs.pop("options", None)
if options is not None and options.get("x_payload_raw", False):
options.pop("x_payload_raw", None)
if len(args) > 1 or len(kwargs) > 0:
if len(args) > 1:
raise TypeError("must provide at most one argument when 'x_payload_raw' is set")

if not isinstance(args[0], bytes):
raise TypeError("argument must be of type byte when 'x_payload_raw' is set")
if len(kwargs) != 0:
raise TypeError("must not provide kwargs when 'x_payload_raw' is set")

call = messages.Call(
messages.CallFields(self._idgen.next(), procedure, options=options, payload=args[0], serializer=0)
)
if len(args) == 0:
call = messages.Call(
messages.CallFields(self._idgen.next(), procedure, options=options, serializer=0, binary=True)
)
else:
if not isinstance(args[0], bytearray):
raise TypeError("argument must be of type bytearray when 'x_payload_raw' is set")

call = messages.Call(
messages.CallFields(
self._idgen.next(),
procedure,
options=options,
payload=args[0],
serializer=0,
binary=True,
)
)
else:
call = messages.Call(messages.CallFields(self._idgen.next(), procedure, args, kwargs, options=options))

Expand Down