Revocable CAT issuance support - #811
Open
Rigidity wants to merge 1 commit into
Open
Conversation
|
Would the wallet include tooling to revoke a coin? I assume that's a bit more complex than issuing. Would it be possible for the RPC to contain an endpoint to revoke if the GUI doesn't? |
Collaborator
Author
Yes, I can add that as well. It's not really hard to implement for individual known coin ids, it's more just that it gets into explorer territory if you need the wallet to also find these revocable coins. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes on-chain CAT issuance semantics and asset metadata when
revocableis enabled; incorrect hidden puzzle hash handling could mint non-revocable or wrongly revocable tokens.Overview
Adds optional revocable CAT issuance end-to-end:
IssueCatgains arevocableflag, the wallet issues with an optional hidden puzzle hash (the wallet change address when revocable), persisted on the asset record, with a wallet test covering the flow.The Issue Token UI adds a revocable switch, inline and confirmation warnings that Sage cannot revoke tokens, and shows revocable yes/no in the issuance confirmation.
Tooling: Specta TypeScript export is moved out of app startup into
export_bindings()and a debug-onlygenerate-bindingsbinary, wired aspnpm generate:bindings. New Cursor rules document generated-artifact and validation expectations.Reviewed by Cursor Bugbot for commit d063c28. Bugbot is set up for automated code reviews on this repo. Configure here.