Repository navigation
bugfix: preserve infinity masks in Ascend TileLang builds. - #2575
Merged
XuZhang99 merged 1 commit intoOct 25, 2026
Merged
Conversation
PixelFlat
requested review from
DongheJin,
DragonFive,
JimHsiung,
Kang-Meng,
XuZhang99,
liutongxuan,
xiao-yu-chen,
yingxudeng and
zhang-minchao
as code owners
October 25, 2026 13:42
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
liutongxuan
approved these changes
Oct 25, 2026
XuZhang99
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix Ascend AOT compilation of
apply_token_bitmaskwhile preserving its negative-infinity masking semantics.TileLang lowers
float("-inf")to-CUDART_INF, but the Ascend compilation environment does not necessarily define that CUDA macro. The generated kernel then fails withuse of undeclared identifier 'CUDART_INF'.CUDART_INFdefinition using__builtin_inff()in this kernel's AOT source generator. No CUDA headers, external compiler definitions, or compiler wrapper are required.-infwith a finite sentinel.Change Type
Validation
Validated on Linux ARM64 / Ascend A3 with CANN 9.0.0:
python setup.py build --device npu --tilelang-jobs 8passed with the original Bisheng compiler and no external infinity macro injection. All three token-bitmask dtype specializations compiled successfully.CUDART_INFerror for all three dtypes with the same compiler.apply_token_bitmask_wrapper_testsampler_testsampler_controls_testsampler_filter_mask_testgit diff --checkpassed.This is a single focused commit. It does not modify TileLang or operator-package dependencies.