Skip to content

fix(ci): regenerate stale router test config - #3224

Closed
gausie wants to merge 1 commit into
mainfrom
sam/fix-stale-router-test-config
Closed

fix(ci): regenerate stale router test config#3224
gausie wants to merge 1 commit into
mainfrom
sam/fix-stale-router-test-config

Conversation

@gausie

@gausie gausie commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Router CI's git-dirty-check is failing on every PR that touches a router path (#3196, #3208), on a file none of them changed.

#3223 added the label argument to @override, which changes the composed demo config:

- directive @override(from: String!)
+ directive @override(from: String!, label: String)

router-tests/testenv/testdata/config.json was not regenerated, so ./update-config-no-edg.sh in CI produces those two lines plus the two corresponding schema version hashes. Regenerated here with the same steps CI runs.

Router CI's path filter didn't include composition/**, so #3223 never ran the dirty check and the staleness landed on main unnoticed. Added it, so a composition change that alters the composed config is caught by the PR making it. Happy to drop that half if you'd rather not have Router CI run on composition PRs.

configWithEdfs.json is stale the same way, but it comes from update-config.sh, which CI doesn't run, so it isn't failing anything and I've left it alone.

Summary by CodeRabbit

  • Chores

    • Continuous integration now runs for changes within the composition configuration area.
  • Tests

    • Updated federation test data to reflect current product subgraph schemas, including support for labeled override directives.
    • Refreshed stored schema and content metadata used during validation.

#3223 added the `label` argument to `@override`, which changes the composed
demo config, but did not regenerate router-tests/testenv/testdata/config.json.
Router CI's path filter did not include composition/**, so that PR never ran
the dirty check and every subsequent PR touching a router path fails on it.

Add composition/** to the filter so composition changes that alter the
composed config are caught by the PR that makes them.
@gausie
gausie requested review from a team as code owners September 9, 2026 10:10
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 8618ee01-af76-4813-94f5-b375317d92a3

📥 Commits

Reviewing files that changed from the base of the PR and between adade22 and 158be67.

📒 Files selected for processing (2)
  • .github/workflows/router-ci.yaml
  • router-tests/testenv/testdata/config.json

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


Walkthrough

The pull request expands Router CI path coverage to include composition changes. It also updates product federation test fixture hashes and @override directive definitions.

Changes

Router composition CI

Layer / File(s) Summary
Product federation fixture updates
router-tests/testenv/testdata/config.json
Updated product subgraph schema hashes and added the optional label argument to affected @override directives.
Composition CI trigger
.github/workflows/router-ci.yaml
Added composition/**/* to the Router CI pull-request path filters.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 158be

Router configuration fixtures now reflect the labeled @override directive, and Router CI runs when composition changes affect composed configuration. No current merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise, descriptive, 44 characters long, and does not include an issue identifier. It accurately describes the stale router test configuration update, which is the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Router image scan failed

❌ Security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-a00b3ffd44db3fa57bdf5c91610af89683f03bcd

Please check the security vulnerabilities found in the PR.

If you believe this is a false positive, please add the vulnerability to the .trivyignore file and re-run the scan.

@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.02%. Comparing base (adade22) to head (158be67).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3224      +/-   ##
==========================================
- Coverage   71.00%   62.02%   -8.99%     
==========================================
  Files         512      266     -246     
  Lines       31785    31575     -210     
  Branches     7852        0    -7852     
==========================================
- Hits        22568    19583    -2985     
- Misses       8045    10455    +2410     
- Partials     1172     1537     +365     

see 778 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gausie

gausie commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

Merged into #3225 to avoid catch 22

@gausie gausie closed this Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant