fix(ci): regenerate stale router test config - #3224
Conversation
#3223 added the `label` argument to `@override`, which changes the composed demo config, but did not regenerate router-tests/testenv/testdata/config.json. Router CI's path filter did not include composition/**, so that PR never ran the dirty check and every subsequent PR touching a router path fails on it. Add composition/** to the filter so composition changes that alter the composed config are caught by the PR that makes them.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (2)
Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. WalkthroughThe pull request expands Router CI path coverage to include composition changes. It also updates product federation test fixture hashes and ChangesRouter composition CI
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to Router configuration fixtures now reflect the labeled 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
Router image scan failed❌ Security vulnerabilities found in image: Please check the security vulnerabilities found in the PR. If you believe this is a false positive, please add the vulnerability to the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3224 +/- ##
==========================================
- Coverage 71.00% 62.02% -8.99%
==========================================
Files 512 266 -246
Lines 31785 31575 -210
Branches 7852 0 -7852
==========================================
- Hits 22568 19583 -2985
- Misses 8045 10455 +2410
- Partials 1172 1537 +365 🚀 New features to boost your workflow:
|
|
Merged into #3225 to avoid catch 22 |
Router CI's
git-dirty-checkis failing on every PR that touches a router path (#3196, #3208), on a file none of them changed.#3223 added the
labelargument to@override, which changes the composed demo config:router-tests/testenv/testdata/config.jsonwas not regenerated, so./update-config-no-edg.shin CI produces those two lines plus the two corresponding schema version hashes. Regenerated here with the same steps CI runs.Router CI's path filter didn't include
composition/**, so #3223 never ran the dirty check and the staleness landed on main unnoticed. Added it, so a composition change that alters the composed config is caught by the PR making it. Happy to drop that half if you'd rather not have Router CI run on composition PRs.configWithEdfs.jsonis stale the same way, but it comes fromupdate-config.sh, which CI doesn't run, so it isn't failing anything and I've left it alone.Summary by CodeRabbit
Chores
Tests