Skip to content

fix: specify serviceAccountName on all the controlplane jobs - #3178

Open
wmuizelaar wants to merge 1 commit into
wundergraph:mainfrom
wmuizelaar:fix_serviceaccount_jobs
Open

fix: specify serviceAccountName on all the controlplane jobs#3178
wmuizelaar wants to merge 1 commit into
wundergraph:mainfrom
wmuizelaar:fix_serviceaccount_jobs

Conversation

@wmuizelaar

@wmuizelaar wmuizelaar commented Aug 21, 2026

Copy link
Copy Markdown

Summary by CodeRabbit

  • Enhancements
    • Control-plane background jobs and scheduled tasks now consistently run under the chart-configured service account.
    • Organization activation, deactivation, seeding, cleanup, migration, and user-management operations receive the appropriate workload identity.
    • Improved deployment consistency and compatibility with environments requiring explicit service-account assignment.

Checklist

Open Source AI Manifesto

This project follows the principles of the Open Source AI Manifesto. Please ensure your contribution aligns with its principles.

When using the helm-charts to deploy cosmo in our environment, I noticed that the serviceAccountName was not used on the jobs. That made me run into various permission errors, so I figured to add this to the various job templates. I hope it's ok I did not create an issue upfront, I will do so for the rest of the fixes / issues I will try to contribute.

@wmuizelaar
wmuizelaar requested a review from a team as a code owner August 21, 2026 14:40

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1ad66192-2934-4fcb-8ea1-94b2626981c1

📥 Commits

Reviewing files that changed from the base of the PR and between 6e0a147 and 7c1a394.

📒 Files selected for processing (8)
  • helm/cosmo/charts/controlplane/templates/activate-organization.yaml
  • helm/cosmo/charts/controlplane/templates/cleanup-old-data-cronjob.yaml
  • helm/cosmo/charts/controlplane/templates/clickhouse-migration.yaml
  • helm/cosmo/charts/controlplane/templates/database-migration.yaml
  • helm/cosmo/charts/controlplane/templates/deactivate-organization.yaml
  • helm/cosmo/charts/controlplane/templates/delete-inactive-orgs.yaml
  • helm/cosmo/charts/controlplane/templates/delete-user.yaml
  • helm/cosmo/charts/controlplane/templates/organization-seed.yaml

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


Walkthrough

The Helm templates for control plane Jobs and CronJobs now set serviceAccountName from the configured chart service account. Existing commands and conditional directives remain functionally unchanged.

Changes

Control plane service account wiring

Layer / File(s) Summary
Job service account wiring
helm/cosmo/charts/controlplane/templates/activate-organization.yaml, helm/cosmo/charts/controlplane/templates/clickhouse-migration.yaml, helm/cosmo/charts/controlplane/templates/database-migration.yaml, helm/cosmo/charts/controlplane/templates/deactivate-organization.yaml, helm/cosmo/charts/controlplane/templates/delete-user.yaml, helm/cosmo/charts/controlplane/templates/organization-seed.yaml
The Jobs now set serviceAccountName from the chart-managed service account. Existing migration commands and Helm conditionals remain unchanged.
CronJob service account wiring
helm/cosmo/charts/controlplane/templates/cleanup-old-data-cronjob.yaml, helm/cosmo/charts/controlplane/templates/delete-inactive-orgs.yaml
The CronJobs now set serviceAccountName from the configured control plane service account. Their closing conditionals remain intact.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 7c1a3

This localized chart change assigns the configured service account to control-plane jobs, addressing permission behavior without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding serviceAccountName to all control-plane jobs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (8 skipped: 8 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants