fix: specify serviceAccountName on all the controlplane jobs - #3178
fix: specify serviceAccountName on all the controlplane jobs#3178wmuizelaar wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. WalkthroughThe Helm templates for control plane Jobs and CronJobs now set ChangesControl plane service account wiring
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This localized chart change assigns the configured service account to control-plane jobs, addressing permission behavior without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary by CodeRabbit
Checklist
Open Source AI Manifesto
This project follows the principles of the Open Source AI Manifesto. Please ensure your contribution aligns with its principles.
When using the helm-charts to deploy cosmo in our environment, I noticed that the serviceAccountName was not used on the jobs. That made me run into various permission errors, so I figured to add this to the various job templates. I hope it's ok I did not create an issue upfront, I will do so for the rest of the fixes / issues I will try to contribute.