Skip to content

fix(controlplane): avoid re-logging caller-supplied seed API key #3170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davideugui1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(controlplane): avoid re-logging caller-supplied seed API key #3170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions controlplane/src/bin/get-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ const getConfig = () => {
apiUrl: process.env.KC_API_URL || 'http://localhost:8080',

apiKey: process.env.API_KEY || ApiKeyGenerator.generate(),
apiKeyWasGenerated: !process.env.API_KEY,

userEmail: process.env.USER_EMAIL || 'foo@wundergraph.com',
userPassword: process.env.USER_PASSWORD || 'wunder@123',
Expand Down
7 changes: 6 additions & 1 deletion controlplane/src/bin/seed.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ const {
clientId,
apiUrl,
apiKey,
apiKeyWasGenerated,
userEmail,
userPassword,
userFirstName,
Expand Down Expand Up @@ -131,7 +132,11 @@ try {
timeout: 1,
});

console.log(`API Key: ${apiKey}`);
if (apiKeyWasGenerated) {
console.log(`API Key: ${apiKey}`);
} else {
console.log('API Key: using the value provided via the API_KEY environment variable');
}
console.log('Done');

// eslint-disable-next-line unicorn/no-process-exit
Expand Down
Loading