Skip to content

feat(router): add metric request timetolastbyte - #3119

Open
alepane21 wants to merge 6 commits into
mainfrom
ale/router-150-router-add-metric-request-timetolastbyte
Open

feat(router): add metric request timetolastbyte#3119
alepane21 wants to merge 6 commits into
mainfrom
ale/router-150-router-add-metric-request-timetolastbyte

fix: remove useless structures

2b9ebc1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 22, 2026 in 0s

62.50% (target 30.00%)

View this Pull Request on Codecov

62.50% (target 30.00%)

Details

Codecov Report

❌ Patch coverage is 84.74576% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.50%. Comparing base (64eaf60) to head (2b9ebc1).
⚠️ Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
router/internal/traceclient/traceclient.go 84.56% 15 Missing and 8 partials ⚠️
router/pkg/metric/connection_measurements.go 0.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3119      +/-   ##
==========================================
+ Coverage   62.37%   62.50%   +0.13%     
==========================================
  Files         262      262              
  Lines       31003    31168     +165     
==========================================
+ Hits        19337    19483     +146     
- Misses      10158    10170      +12     
- Partials     1508     1515       +7     
Files with missing lines Coverage Δ
router/internal/expr/expr.go 95.74% <ø> (ø)
router/pkg/metric/connection_metric_store.go 75.75% <100.00%> (+3.34%) ⬆️
router/pkg/metric/noop_connection_metrics.go 65.21% <100.00%> (+7.32%) ⬆️
router/pkg/metric/oltp_connection_metric_store.go 75.75% <100.00%> (+12.42%) ⬆️
router/pkg/metric/prom_connection_metric_store.go 75.75% <100.00%> (+2.42%) ⬆️
router/pkg/metric/connection_measurements.go 50.00% <0.00%> (-5.56%) ⬇️
router/internal/traceclient/traceclient.go 91.74% <84.56%> (-5.85%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.