Repository navigation
Conversation
GustawB
force-pushed
the
ti-cc2650-rewritten
branch
from
April 10, 2026 17:54
edc536b to
c5e227c
Compare
Author
|
Hey @wprzytula, could you take a look at this? |
wprzytula
reviewed
Apr 20, 2026
Comment on lines
29
to
33
| #[cfg(not(test))] | ||
| #[no_mangle] | ||
| #[inline(never)] | ||
| #[panic_handler] | ||
| /// Panic handler | ||
| pub unsafe fn panic_fmt(pi: &core::panic::PanicInfo) -> ! { |
Author
There was a problem hiding this comment.
Then I get:
error: #[no_mangle] cannot be used on internal language items
Owner
|
Have you tested this on the device? |
Author
Yep, I played with the radio examples. |
Owner
|
The CI is failing. Please make it pass. |
Author
But it didn't pass before either, e.g. for ee8d326 which seems to be the last commit on this branch before my PR. |
wprzytula
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request introduces fixes for building the project in 2026
Testing Strategy
This pull request was tested manually by @GustawB