Refactor server/pipeline package#6649
Open
6543 wants to merge 9 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6649 +/- ##
==========================================
+ Coverage 41.73% 42.16% +0.42%
==========================================
Files 433 434 +1
Lines 28930 28920 -10
==========================================
+ Hits 12075 12195 +120
+ Misses 15765 15623 -142
- Partials 1090 1102 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
qwerty287
reviewed
May 27, 2026
| // the shared tail of Create, Approve and Restart: the caller has already | ||
| // persisted the pipeline and its workflows and set the final pre-dispatch | ||
| // status. | ||
| func finishPipeline(ctx context.Context, _forge forge.Forge, _store store.Store, pipeline *model.Pipeline, user *model.User, repo *model.Repo, pipelineItems []*builder.Item) (*model.Pipeline, error) { |
Contributor
There was a problem hiding this comment.
finishPipeline is a weird name for a function that actually starts the pipeline. Maybe finishPipelineStart?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get rid of some spagetii code in server/pipeline
and consistend naming