Add CRL extraction logic by stenslae · Pull Request #275 · wolfSSL/wolfCLU

stenslae · 2026-07-15T22:44:51Z

Introduces fully integrated CRL (Certificate Revocation List) loading and verification support.

Depends on #276

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #275

Scan targets checked: wolfclu-bugs, wolfclu-src

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #275

Scan targets checked: wolfclu-bugs, wolfclu-src

No new issues found in the changed files. ✅

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #275

Scan targets checked: wolfclu-bugs, wolfclu-src

No new issues found in the changed files. ✅

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #275

Scan targets checked: wolfclu-bugs, wolfclu-src

Findings: 3
3 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #275

Scan targets checked: wolfclu-bugs, wolfclu-src

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #275

Scan targets checked: wolfclu-bugs, wolfclu-src

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #275

Scan targets checked: wolfclu-bugs, wolfclu-src

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #275

Scan targets checked: wolfclu-bugs, wolfclu-src
Findings: 2

Low (2)

No-op selfSigned guard in wolfCLU_BuildAndSignNative

File: src/x509/clu_cert_setup.c:1969
Function: wolfCLU_BuildAndSignNative
Category: Dead/unreachable code

wolfCLU_X509FillCert is called with caCert=NULL, which already unconditionally sets cert->selfSigned = 1 internally; the !isCSR guarded reassignment has no effect for either CSR or cert generation.

Recommendation: Remove the redundant reassignment, or pass appropriate caCert semantics so the !isCSR condition actually differentiates behavior.

Referenced code: src/x509/clu_cert_setup.c:1969-1971 (3 lines)

No-op selfSigned guard in wolfCLU_CertSignNative

File: src/x509/clu_x509_sign.c:1881
Function: wolfCLU_CertSignNative
Category: Dead/unreachable code

wolfCLU_X509FillCert already sets cert->selfSigned = 1 whenever caCert == x509 (or NULL); this follow-up assignment duplicates that with no observable effect.

Recommendation: Remove the redundant block since wolfCLU_X509FillCert already computes selfSigned from caCert/x509.

Referenced code: src/x509/clu_x509_sign.c:1881-1883 (3 lines)

This review was generated automatically by Fenrir. Findings are non-blocking.

stenslae requested a review from wolfSSL-Fenrir-bot July 15, 2026 22:44

stenslae self-assigned this Jul 15, 2026

stenslae force-pushed the pr-pem-only branch from fbc3670 to f82d725 Compare July 27, 2026 20:39

stenslae changed the base branch from main to pr-x509-only July 27, 2026 20:43

stenslae force-pushed the pr-x509-only branch from 69b86b3 to 0f442b4 Compare July 27, 2026 20:45

stenslae requested review from wolfSSL-Fenrir-bot and removed request for wolfSSL-Fenrir-bot July 27, 2026 20:45

stenslae force-pushed the pr-pem-only branch from f82d725 to a4eab0a Compare July 27, 2026 20:45

wolfSSL-Fenrir-bot reviewed Jul 27, 2026

View reviewed changes

Comment thread src/sign-verify/clu_x509_verify.c Outdated

stenslae force-pushed the pr-x509-only branch from 0f442b4 to 6ea47a9 Compare July 27, 2026 21:08

stenslae commented Jul 27, 2026

View reviewed changes

Comment thread src/sign-verify/clu_x509_verify.c Outdated

stenslae force-pushed the pr-pem-only branch from a4eab0a to 1f18deb Compare July 27, 2026 21:16

stenslae requested a review from wolfSSL-Fenrir-bot July 27, 2026 21:16

stenslae marked this pull request as ready for review July 27, 2026 21:17

stenslae force-pushed the pr-pem-only branch 3 times, most recently from ad17d95 to 23283ad Compare July 27, 2026 22:41

stenslae force-pushed the pr-x509-only branch from 6ea47a9 to 88a4640 Compare July 27, 2026 22:45

stenslae requested review from wolfSSL-Fenrir-bot and removed request for wolfSSL-Fenrir-bot July 28, 2026 15:20

wolfSSL-Fenrir-bot reviewed Jul 28, 2026

View reviewed changes

stenslae assigned wolfSSL-Bot and stenslae and unassigned stenslae Jul 28, 2026

stenslae force-pushed the pr-pem-only branch from 23283ad to 9eb3e5e Compare July 28, 2026 16:17

stenslae requested a review from wolfSSL-Fenrir-bot July 28, 2026 16:26

wolfSSL-Fenrir-bot reviewed Jul 28, 2026

View reviewed changes

stenslae force-pushed the pr-pem-only branch from 9eb3e5e to d23a2d2 Compare July 28, 2026 16:48

stenslae force-pushed the pr-x509-only branch from 88a4640 to f387bb3 Compare July 28, 2026 16:48

stenslae force-pushed the pr-pem-only branch from d23a2d2 to 14aa0a4 Compare July 28, 2026 16:52

stenslae requested a review from wolfSSL-Fenrir-bot July 28, 2026 23:22

wolfSSL-Fenrir-bot reviewed Jul 28, 2026

View reviewed changes

Comment thread src/x509/clu_x509_sign.c

Comment thread src/x509/clu_cert_setup.c

Comment thread wolfclu/clu_header_main.h Outdated

philljj unassigned wolfSSL-Bot Jul 29, 2026

stenslae commented Jul 29, 2026

View reviewed changes

Comment thread wolfclu/clu_header_main.h Outdated

stenslae commented Jul 29, 2026

View reviewed changes

Comment thread src/x509/clu_cert_setup.c

stenslae force-pushed the pr-pem-only branch from d847dfc to 0fc5ce1 Compare July 29, 2026 17:14

stenslae commented Jul 29, 2026

View reviewed changes

Comment thread src/x509/clu_x509_sign.c

stenslae force-pushed the pr-x509-only branch from 31c5514 to 4ac1c09 Compare July 29, 2026 17:19

stenslae requested a review from wolfSSL-Fenrir-bot July 29, 2026 17:31

stenslae force-pushed the pr-x509-only branch from 8e1c995 to c4337d6 Compare July 29, 2026 17:32

stenslae force-pushed the pr-pem-only branch from 0fc5ce1 to b2e5231 Compare July 29, 2026 17:35

wolfSSL-Fenrir-bot reviewed Jul 29, 2026

View reviewed changes

Comment thread src/sign-verify/clu_x509_verify.c

stenslae commented Jul 29, 2026

View reviewed changes

Comment thread src/sign-verify/clu_x509_verify.c

stenslae force-pushed the pr-pem-only branch from b2e5231 to b86974a Compare July 29, 2026 17:54

stenslae requested a review from wolfSSL-Fenrir-bot July 29, 2026 18:49

wolfSSL-Fenrir-bot reviewed Jul 29, 2026

View reviewed changes

Comment thread src/sign-verify/clu_x509_verify.c Outdated

stenslae commented Jul 29, 2026

View reviewed changes

Comment thread src/sign-verify/clu_x509_verify.c Outdated

stenslae force-pushed the pr-pem-only branch from b86974a to d4b084f Compare July 29, 2026 21:12

stenslae requested a review from wolfSSL-Fenrir-bot July 29, 2026 21:13

wolfSSL-Fenrir-bot reviewed Jul 29, 2026

View reviewed changes

Comment thread wolfclu/x509/clu_cert.h

stenslae commented Jul 29, 2026

View reviewed changes

Comment thread wolfclu/x509/clu_cert.h

stenslae force-pushed the pr-pem-only branch from d4b084f to 20f0ad2 Compare July 29, 2026 21:43

stenslae requested a review from wolfSSL-Fenrir-bot July 29, 2026 21:44

stenslae force-pushed the pr-x509-only branch from c4337d6 to e4ea143 Compare July 29, 2026 21:56

wolfSSL-Fenrir-bot reviewed Jul 29, 2026

View reviewed changes

stenslae force-pushed the pr-pem-only branch from 20f0ad2 to c140a03 Compare July 29, 2026 22:03

stenslae force-pushed the pr-x509-only branch from e4ea143 to a09fd6d Compare July 29, 2026 22:04

Add custom PEM bundle parsing and CRL extraction logic

c1fbe19

stenslae force-pushed the pr-pem-only branch from c140a03 to c1fbe19 Compare July 29, 2026 22:06

stenslae force-pushed the pr-x509-only branch from a09fd6d to 0592d3a Compare July 29, 2026 22:07

Uh oh!

Conversation

stenslae commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #275

Uh oh!

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #275

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #275

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #275

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #275

Uh oh!

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #275

Uh oh!

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #275

Uh oh!

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #275

Low (2)

No-op selfSigned guard in wolfCLU_BuildAndSignNative

No-op selfSigned guard in wolfCLU_CertSignNative

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

stenslae commented Jul 15, 2026 •

edited

Loading